Add ability to parse section from in memory buffer #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
val-ms
force-pushed
the
CLAM-2329-new-from-slice
branch
from
c155f31 to
8b45044
Compare
|
Er I meant to ping this one 🫢, not the github issue. |
|
It would be very helpful for Fedora packaging if this was applied. Is this project still active, or should we consider the https://github.com/Cisco-Talos/onenote.rs fork as canonical now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #12
This is a rather simple solution I've made that gets the job done. Perhaps a better implementation would read from anything that implements the Reader trait. Like how it is done in the rust-delharc crate. But I think that would require more extensive changes to your
Readermodule.