Vulnerable to similar screen sessions

[marcuswhybrow]

As seen in issue #23 (specifically this comment) MSM fails to stop servers when multiple screen sessions are found matching the expected name. Guards must be put in place to gracefully deal with this problem or eliminate it.

A solution may be to append salt data to the screen name on each start up, save that to file and check it subsequently. Or just be damn sure a screen session is dead when stopping servers.

[k1n6b0b]

same problem here. somehow got 2 screens running and all msm commands stopped working (problem for me because I crontab start/stop my server). Posting to follow to resolution :)

[PugTsurani]

I fixed this by getting the PID of the Java process after spawning the screen session and saving it in SERVER_PATH/SERVER_NAME.pid. This is used to accurately determine if the server is running and prevents another screen session from starting. How do I give the changes back to the community? I'm new to GitHub.

[FabianN]

@PugTsurani
Start here: https://help.github.com/articles/set-up-git
Then go over 'Fork A Repository' and 'Be Social'

That should get you going.

[PugTsurani]

Awesome! Thanks for the tip, @FabianN.

[TrogloGeek]

I had similar problem when a server name includes another (I had "zavxmieux" and "zavxmieux-test"), I solved it setting DEFAULT_SCREEN_NAME="msm-{SERVER_NAME}-#screen"
If this could be of any help...
There still is a problem if you change JAR_PATH or RAM on a running server because new SERVER_INVOCATION won't match the running process.
I plan to just issue an error when trying to change one of those two properties on a running server. But handmade modification of those msm-* properties is still a problem (which is not a problem for me, it will only be changed by using msm command on my server.
One dirty solution would be to temporary set SERVER_RAM and SERVER_JAR_PATH to wildcards and unset them right after when filtering ps output with grep...

Or, why not to filter grep output with SERVER_PATH instead of full SERVER_INVOCATION ?