Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can was broken without option CONFIG_DEBUG_FS #17

Open
jencha opened this issue Nov 26, 2020 · 0 comments
Open

Can was broken without option CONFIG_DEBUG_FS #17

jencha opened this issue Nov 26, 2020 · 0 comments

Comments

@jencha
Copy link

jencha commented Nov 26, 2020

Branches: 4.14-rpi...mcp25..fd-v..
I disabled option CONFIG_DEBUG_FS in my kernel config.
Driver compiled successful. Then I tested with cangen/candump in FD mode.
Candump doesn't get messages.

My notices:

  1. Please, add "{}" to the describing DEBUG macroses (file mcp25xxfd_can_debugfs.h)
  2. In the file mcp25xxfd_can.h variable submit_queue_count incremented through DEBUG macros.
    I think, it is bug's decision.
    static inline
    void mcp25xxfd_can_queue_frame(struct mcp25xxfd_can_priv *cpriv,
    s32 fifo, u16 ts, bool is_rx)
    {
    ...
    MCP25XXFD_DEBUGFS_INCR(cpriv->fifos.submit_queue_count);
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant