Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Did this break recently? #8

Closed
Avaq opened this issue Mar 12, 2021 · 4 comments
Closed

Did this break recently? #8

Avaq opened this issue Mar 12, 2021 · 4 comments

Comments

@Avaq
Copy link

Avaq commented Mar 12, 2021

Thank you for this script, it's been of great help up until this point. :)
I'm running into an issue and maybe you know more.

My VSCode Liveshare stopped working a few days ago. I made sure to:

  • Update nixos-vsliveshare
  • Rerun fix-vsliveshare
  • Reinstall the Livehsare plugin

One of these things sure did the trick before, but doesn't now.
Now when I press the "Share" or "Join" buttons, nothing happens.

@Avaq
Copy link
Author

Avaq commented Mar 12, 2021

I just got it to work again by downgrading, as described in the README, to version 1.0.3784. I was not able to get it to work on either 1.0.3912 or 1.0.3968.

@msteen
Copy link
Owner

msteen commented Mar 12, 2021

Thanks for reporting! This issue (I believe) has been fixed in a sort of fork of this project that does not require some of patching I am doing:
NixOS/nixpkgs#41189 (comment)

I will see this weekend if I should just end this project in favor of the above, or whether mine still has some use (will have to do some tests to determine that).

@Avaq
Copy link
Author

Avaq commented Mar 12, 2021

Oh, thanks for the link! That certainly looks interesting. I'll try it out, if nixos-vsliveshare works better for me for whatever reason I'll let you know! :)

@Avaq
Copy link
Author

Avaq commented Mar 12, 2021

This new approach works perfectly for me. I got a working version of 1.0.3912. Thank you again for providing nixos-vsliveshare for as long as it was needed. :)

@msteen msteen closed this as completed Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants