-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish to NPM #18
Comments
It is published in Bower. Could you convince me to publish to NPM in addition? |
I had to do a lot of extra work to get it working in Browserify or Webpack. Lots of developers use those tools. Also, NPM is the largest module repository. |
It looks not so complicated. Now dependencies of the component are managed by Bower and they are: "dependencies": {
"requirejs": "2.1.15",
"d3": "3.5.3",
"requirejs-web-workers": "~1.0.1",
"viz.js": "~1.3.0"
} Should I put these in |
Installing those via npm should work. I also had to use a worker loader to make it work in webpack instead of the requirejs loader you have in your repo. https://www.npmjs.com/package/worker-loader |
Could you create a pull request for that? |
Worker-loader is something the developer would add to their build process. Would you like me to add that to the documentation? |
My component uses worker plugin to load parsing and rendering WebWorker. Do you suggest to replace one plugin with another by component end developer? |
Yes. You are using the requirejs web worker plugin. Webpack and Browserify have a similar module called worker-loader. Here is a list of the changes I had to make to get this module working with Webpack:
After these changes, no dependency paths need to be added to a config file. |
Do it, please. Current build and test process relies on Bower so take it also into account. |
Hey, an NPM package to use with webpack sounds good to me too. @akinnee-gl Is there anything you need besides encouragmenent to get that pull request? Perhaps you could share your branch? |
Actually, because this doesn't support all of the functionality of Viz.js, I ended up just using Viz.js directly. |
@akinnee-gl Would you kindly share your |
Personally I would recommend you just use Viz.js. It's less complicated and it's already on npm. If you really need to animate your svg, you can still do that using D3 separately. |
It would be awesome if this were published to NPM!
The text was updated successfully, but these errors were encountered: