Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omSupply Desktop returns a blank screen when Caddy is off (AKA Invalid SSL Cert) #4893

Open
marthakeezy opened this issue Sep 26, 2024 · 1 comment
Labels
bug Something is borken Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release.

Comments

@marthakeezy
Copy link

marthakeezy commented Sep 26, 2024

What went wrong? 😲

If Desktop isn't able to connect to the server due to an SSL Certificate issue, the desktop app doesn't show any error.

Interestingly with developer tools open the error is shown!

Screenshot 2024-09-27 at 10 19 01 AM Screenshot 2024-09-27 at 10 19 14 AM

Thank you @jmbrunskill 🙏🏼 🙏🏼 🙏🏼

Not sure what the severity is, it depends a bit on if this is a pattern we see in our install base.
So far it's primarily affecting testers...

Expected behaviour 🤔

If there's an ssl certificate error connecting to the server this should be displayed clearly to the user.

Possibly we should allow the user to connect even with invalid cert? - Add trust for a particular cert perhaps?

We should probably create a way to allow the user to specify a URL manually rather than relying entirely on discovery?

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Setup your open-mSupply server to use a certificate for a domain name aka test.msupply.org
  2. Start desktop locally on the server
  3. Connect to the IP Address shown (IP Address doesn't have a valid cert)
  4. Connection fails...

Your environment 🌱

  • Open mSupply Version: V2.3.0-RC1
  • Legacy mSupply Central Server Version: V7.17.10
  • Platform: Desktop (Windows); Central Server
  • Database type: SQLite3
@marthakeezy marthakeezy added bug Something is borken needs triage needs daily triage New bug to be triaged by the release team Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. labels Sep 26, 2024
@roxy-dao roxy-dao changed the title omSupply Desktop returns a blank screen when Caddy is off (issue for James) omSupply Desktop returns a blank screen when Caddy is off Sep 26, 2024
@jmbrunskill jmbrunskill changed the title omSupply Desktop returns a blank screen when Caddy is off omSupply Desktop returns a blank screen when Caddy is off (AKA Invalid SSL Cert) Sep 26, 2024
@roxy-dao roxy-dao modified the milestone: v2.3.0-RC2 Sep 26, 2024
@lache-melvin lache-melvin removed the needs daily triage New bug to be triaged by the release team label Sep 27, 2024
@jmbrunskill jmbrunskill added Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release and removed Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. labels Sep 29, 2024
@andreievg
Copy link
Collaborator

Make sure error like this appears on screen, if can't be replicated don't spend too much time trying to replicate.

There is prosed work around/solutions for this in #5080

@andreievg andreievg added Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release. and removed Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release Needs refinement labels Oct 10, 2024
@andreievg andreievg added this to the Refactor fortnight milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release.
Projects
None yet
Development

No branches or pull requests

5 participants