You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I unified this in one issue because we need to take all of these into account in the solution.
Socket authorized and encrypted are false for https requests
https.get('https://example.test').on('socket',socket=>{expect(socket.authorized).to.equal(true)// always false, test failsexpect(socket.encrypted).to.equal(true)// always false, test failsdone()})
never emit (socket) connect event for an invalid URL (e.g. example.test) because Node tries to connect to the URL, and we capture the ENOTFOUND.
We can't use socket.setTimeout for invalid URL (e.g. example.test`) because it emits error
The text was updated successfully, but these errors were encountered:
mikicho
changed the title
Set socket authorized and encrypted to true for https requests
Socket authorized and encrypted are false for https requests
Sep 28, 2023
mikicho
changed the title
Socket authorized and encrypted are false for https requests
Fix socket behaviour
Sep 29, 2023
I unified this in one issue because we need to take all of these into account in the solution.
connect
event for an invalid URL (e.g.example.test
) because Node tries to connect to the URL, and we capture theENOTFOUND
.socket.setTimeout
for invalid URL (e.g. example.test`) because it emits errorThe text was updated successfully, but these errors were encountered: