python2/3, isatty and stdout buffering #2645
Comments
|
Use winpty Oh yeah, there was also #2555 with https://github.com/k-takata/MINGW-packages/blob/1f39e95a74f1e4d4aca928d8009614f98b6a4853/mingw-w64-ag/0002-win32-Detect-Cygwin-MSYS-PTY.patch But really, just use winpty and you'll be fine |
|
winpty is indeed nice, thanks. But it's not that obvious and tedious to type before each command. Then my question is why isn't "winpty bash" not the default mingw shell? |
|
Well, just guessing here, but there's a non-zero cost associated with using winpty, and most of the time, mintty works fine anyway. Your problem stems from trying to use mingw python which is a native windows build, and hence expects it to be used from a windows console. mintty uses pipes for input/output, so it doesn't look like a proper terminal to most programs. On the other hand, if you use msys2 (or cygwin) python (.e.g /usr/local/bin/python2), everything just works. Anyway, I'm pretty sure you can also just edit the default console to not be mintty, although I don't know the full details of this. Try looking/modifying the batch file that starts msys2. Or you can just call bash.exe ( |
|
Hm, found a downside with winpty, it doesn't allow inputing umlauts (öäü..) in Python. A bit of a deal breaker I guess. It also seems a tiny bit slower, but I wouldn't mind that in exchange for proper program behavior. |
|
If anyone thinks that adjusting isatty() in Python is a good idea I can provide patches. If not feel free to close this. |
|
I'm fine with that personally. ag was recently patched in this way, maybe you can reuse the code? There was talk of trying to upstream to mingw-w64 a msys2/cygwin sympathetic isatty, does anyone know what happened with that effort? |
|
Sorry for the potentially off-topic question: could it be a similar reason why msys2 is not working in docker and no stdout is written to the console? |
…a real Windows console CPython uses isatty() to detect a terminal and change some settings like line buffering and interactive mode. Use is_cygpty() to make this also work under mintty. See https://github.com/Alexpux/MINGW-packages/issues/2645 This also removes the bash script which forced the interactive mode when python3 was started without arguments. This is no longer needed as Python now detects the terminal output and does this automatically. Also use is_cygpty() to detect when not under mintty and disable the readline module there, as using it breaks input of certain characters and leads to errors on shutdown when it tries to save the readline history. (The readline module is not available in the official Python build) See https://github.com/Alexpux/MINGW-packages/issues/2656
|
@peterbud no idea, sorry I've opened a PR #2675 for Python 3 for starters. That fixes line buffering, interactive detection with mintty and unicode input with winpty. The interactive mode using readline is still weird (arrows keys do the wrong thing), maybe due to readline not detecting the terminal as well... |
…a real Windows console CPython uses isatty() to detect a terminal and change some settings like line buffering and interactive mode. Use is_cygpty() to make this also work under mintty. See https://github.com/Alexpux/MINGW-packages/issues/2645 This also removes the bash script which forced the interactive mode when python3 was started without arguments. This is no longer needed as Python now detects the terminal output and does this automatically. Also use is_cygpty() to detect when not under mintty and disable the readline module there, as using it breaks input of certain characters and leads to errors on shutdown when it tries to save the readline history. (The readline module is not available in the official Python build) See https://github.com/Alexpux/MINGW-packages/issues/2656
…a real Windows console (#2675) CPython uses isatty() to detect a terminal and change some settings like line buffering and interactive mode. Use is_cygpty() to make this also work under mintty. See https://github.com/Alexpux/MINGW-packages/issues/2645 This also removes the bash script which forced the interactive mode when python3 was started without arguments. This is no longer needed as Python now detects the terminal output and does this automatically. Also use is_cygpty() to detect when not under mintty and disable the readline module there, as using it breaks input of certain characters and leads to errors on shutdown when it tries to save the readline history. (The readline module is not available in the official Python build) See https://github.com/Alexpux/MINGW-packages/issues/2656
|
Most things should be fixed now.
|
Python2/3 stdout not being line buffered under minttty is annoying so I'm wondering what would be the best fix here:
The text was updated successfully, but these errors were encountered: