Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virus reported in msys2-x86_64-20200719.exe - "Trojan:Win32/Tnega.AMK!MSR" #11

Closed
SillyKeith opened this issue Jul 19, 2020 · 8 comments

Comments

@lazka
Copy link
Member

lazka commented Jul 20, 2020

So, while I sadly don't have the checksums of the files when they were created on azure pipelines to ensure they weren't modified between build and release I had the github release API responses cached in my browser, and at least the filesize matches between the old nightly tag asset and the release:

Old Nightly:

      {
        "url": "https://api.github.com/repos/msys2/msys2-installer/releases/assets/23019157",
        "id": 23019157,
        "node_id": "MDEyOlJlbGVhc2VBc3NldDIzMDE5MTU3",
        "name": "msys2-x86_64-20200719.exe",
        "label": "",
        "uploader": {
          "login": "lazka",
          "id": 991986,
          "node_id": "MDQ6VXNlcjk5MTk4Ng==",
          "avatar_url": "https://avatars2.githubusercontent.com/u/991986?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/lazka",
          "html_url": "https://github.com/lazka",
          "followers_url": "https://api.github.com/users/lazka/followers",
          "following_url": "https://api.github.com/users/lazka/following{/other_user}",
          "gists_url": "https://api.github.com/users/lazka/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/lazka/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/lazka/subscriptions",
          "organizations_url": "https://api.github.com/users/lazka/orgs",
          "repos_url": "https://api.github.com/users/lazka/repos",
          "events_url": "https://api.github.com/users/lazka/events{/privacy}",
          "received_events_url": "https://api.github.com/users/lazka/received_events",
          "type": "User",
          "site_admin": false
        },
        "content_type": "application/x-msdownload",
        "state": "uploaded",
        "size": 91931862,
        "download_count": 2,
        "created_at": "2020-07-19T07:12:31Z",
        "updated_at": "2020-07-19T07:12:38Z",
        "browser_download_url": "https://github.com/msys2/msys2-installer/releases/download/nightly-x86_64/msys2-x86_64-20200719.exe"
      },

Release:

      {
        "url": "https://api.github.com/repos/msys2/msys2-installer/releases/assets/23020116",
        "id": 23020116,
        "node_id": "MDEyOlJlbGVhc2VBc3NldDIzMDIwMTE2",
        "name": "msys2-x86_64-20200719.exe",
        "label": null,
        "uploader": {
          "login": "lazka",
          "id": 991986,
          "node_id": "MDQ6VXNlcjk5MTk4Ng==",
          "avatar_url": "https://avatars2.githubusercontent.com/u/991986?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/lazka",
          "html_url": "https://github.com/lazka",
          "followers_url": "https://api.github.com/users/lazka/followers",
          "following_url": "https://api.github.com/users/lazka/following{/other_user}",
          "gists_url": "https://api.github.com/users/lazka/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/lazka/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/lazka/subscriptions",
          "organizations_url": "https://api.github.com/users/lazka/orgs",
          "repos_url": "https://api.github.com/users/lazka/repos",
          "events_url": "https://api.github.com/users/lazka/events{/privacy}",
          "received_events_url": "https://api.github.com/users/lazka/received_events",
          "type": "User",
          "site_admin": false
        },
        "content_type": "application/x-msdownload",
        "state": "uploaded",
        "size": 91931862,
        "download_count": 183,
        "created_at": "2020-07-19T07:27:05Z",
        "updated_at": "2020-07-19T07:27:43Z",
        "browser_download_url": "https://github.com/msys2/msys2-installer/releases/download/2020-07-19/msys2-x86_64-20200719.exe"
      },

To prevent this kind of uncertainty in the future I've made the nightly job log the checksums and also upload them to the release tag in 6eca2a3 for future builds.

@lazka
Copy link
Member

lazka commented Jul 20, 2020

Thanks for your report!

@lazka lazka closed this as completed Jul 20, 2020
@SillyKeith
Copy link
Author

SillyKeith commented Jul 21, 2020 via email

@impeeza
Copy link

impeeza commented Jul 26, 2020

Hi I Have Windows 10 1909 at latest version,

image

trying to use msys2-x86_64-20200720.exe (4901f64b0e47e0ebc9a15145abe57c1e MD5)
I get the next warning:

image

@Biswa96
Copy link
Member

Biswa96 commented Jul 26, 2020

@impeeza This does not seem to be a virus alert. Right click on the downloaded file, select properties, tick the 'Unblock' check box and press OK.

@impeeza
Copy link

impeeza commented Jul 26, 2020

Hi, you are right is not a Virus Alert is a Smart Screen Alert, is based on «Reputation» generally means the file has been downloaded very few times. MS and his big nose...

@ADTC
Copy link

ADTC commented Jun 8, 2021

Right click on the downloaded file, select properties, tick the 'Unblock' check box and press OK.

is not a Virus Alert is a Smart Screen Alert, is based on «Reputation» generally means the file has been downloaded very few times.

Didn't know this was a thing. Perhaps, a notice on the download page would be in order?

PS: Have you considered getting an EV code signing certificate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants