Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MSYSTEM=UCRT64 #125

Closed
szhorvat opened this issue Apr 17, 2021 · 7 comments
Closed

Support MSYSTEM=UCRT64 #125

szhorvat opened this issue Apr 17, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@szhorvat
Copy link

This is a request to support UCRT64 packages.

Currently, setting msystem to UCRT64 gives:

Error: 'msystem' needs to be one of MSYS, MINGW32, MINGW64, got UCRT64
@lazka
Copy link
Member

lazka commented Apr 17, 2021

sounds good

@eine
Copy link
Collaborator

eine commented Apr 18, 2021

This was tested in https://github.com/msys2/setup-msys2/actions/runs/760606594 but it seems to fail for no obvious reason. env | grep MSYSTEM does work, but env | grep MINGW crashes. Locally, execution is correct:

grep MSYSTEM
MSYSTEM=UCRT64
MSYSTEM_CARCH=x86_64
MSYSTEM_CHOST=x86_64-w64-mingw32
MSYSTEM_PREFIX=/ucrt64
grep MINGW
MINGW_PREFIX=/ucrt64
MINGW_CHOST=x86_64-w64-mingw32
MINGW_PACKAGE_PREFIX=mingw-w64-ucrt-x86_64

@eine eine added enhancement New feature or request help wanted Extra attention is needed labels Apr 18, 2021
@lazka
Copy link
Member

lazka commented Apr 18, 2021

needs a new installer I think, I'll have a look

@lazka
Copy link
Member

lazka commented Apr 19, 2021

should work now

@eine eine removed the help wanted Extra attention is needed label Apr 20, 2021
@eine
Copy link
Collaborator

eine commented Apr 20, 2021

A new release of the action was just published. @szhorvat, rerunning your workfow should pass now, as long as you are using v2.

@eine eine closed this as completed Apr 20, 2021
@lazka
Copy link
Member

lazka commented Apr 20, 2021

Thanks!

@szhorvat
Copy link
Author

rerunning your workfow should pass now, as long as you are using v2.

It does, thanks for enabling this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants