-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated fork - with some PRs #60
Comments
Thanks! (I know there's no CLA, but I happily consent to this.) |
@ddugovic yeah, didn't really think of that! But I am hoping that the PRs I merged are okay ;) |
When the maintainer prefers to leave the code as is, there's certainly no harm in forking, in fact I'd recommend it. As for CLAs https://ben.balter.com/2018/01/02/why-you-probably-shouldnt-add-a-cla-to-your-open-source-project/ That article suggests projects are better if without them. |
It seems there is no reaction anymore from Toyoda-san. |
Given the amount of issues/PRs that are open for sl (on my fork), I'm not sure it's a good idea that I maintain the fork anymore. Most likely someone with more time, that still uses sl would be better. |
In the end it doesn't matter if it is your fork, this repo (you take over) or another fork. Important is that something is rolling. 😄 IMHO in the first place it is important that the maintainer of this repo state in the README the current situation. The repo is dead (and this is OK). |
Seems like someone picked up your fork. |
Oh nice! Hopefully they are better at it than me :D |
It's a shame that the repo does not allow issues, unsure why however. |
I have forked this repo and merged some of the PRs I found the most interesting and relevant.
If you feel like anything else should be included or changed, please do make an issue with the fork and or do a new PR!
here
Thanks!
The text was updated successfully, but these errors were encountered: