-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cypress for end-to-end testing #8
Comments
After installing locally, got a whole bunch of these eslint errors
Seems likely that Jest and Cypress globals are conflicting: typescript-eslint/typescript-eslint#2298 (comment) There's a specific eslint plugin for Cypress but seems unlikely this will solve the issue as it's probably Typescript related: https://github.com/cypress-io/eslint-plugin-cypress Cypress have a suggested way of splitting the TS config to separate them both: https://github.com/cypress-io/cypress-and-jest-typescript-example |
A secondary problem has arisen, that when I try to exclude the
There's a discussion and some suggestions here typescript-eslint/typescript-eslint#1192 (comment) which basically boil down to go with:
|
It would likely be difficult to tackle these two issues at once. Might be best to remove Cypress and restructure TS and ESLint configs that abide by recommendations from Cypress (about avoiding clashes with Jest) and the performance recommendations from the last comment |
Will starting from scratch and adding one package at a time
After each step, need to test: |
After attempting the above strategy, and re-reading the suggestions in the linked issues (which I think I misunderstood first time), I decided to change approach. Instead I've separated the 6 packages more cleanly and do type/eslint linting separately on all 6 of them, and only on those 6. This should allow Cypress to be added to another folder and the existing Typescript and ESlint configs won't apply to it. And they shouldn't pollute each others' namespaces Done in 8455737 |
This link suggested creating a separate TS config for linting that doesn't include test files, e.g. https://github.com/cypress-io/cypress-and-jest-typescript-example |
No description provided.
The text was updated successfully, but these errors were encountered: