Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

[v5.4.1/jp.js] Grammar issues #296

Closed
Hiro527 opened this issue Jan 31, 2022 · 4 comments
Closed

[v5.4.1/jp.js] Grammar issues #296

Hiro527 opened this issue Jan 31, 2022 · 4 comments
Labels
grammar-issues grammar issues high-priority High Priority

Comments

@Hiro527
Copy link
Contributor

Hiro527 commented Jan 31, 2022

I found that there are some grammar issues in sentences for challenges.
For example:

chall.name.hs Get {0} headshots {1}

The sentence above will be like "Get 50 headshots in Sandstorm". "50" fills {0} and "in Sandstorm" fills {1}. But in Japanese, it should be like "Sandstormで50回ヘッドショット". "Sandstorm" will be {0} so that "50" will be {1}. There's differences that can't be resolved easily between English and Japanese. We've talked about similar issues and we've left it as it as so that I'll open new pr that doesn't include changes for this section.

@Hiro527 Hiro527 added help wanted Extra attention is needed grammar-issues grammar issues labels Jan 31, 2022
@YuniQ152
Copy link
Contributor

YuniQ152 commented Feb 1, 2022

Same grammar issue in Korean.

@mty22
Copy link
Owner

mty22 commented Feb 2, 2022

This issue is systemic. I'll have a chat with the devs about it when time permits. For now, best to leave it in English.

@mty22 mty22 added high-priority High Priority and removed help wanted Extra attention is needed labels Feb 2, 2022
@Hiro527 Hiro527 linked a pull request Feb 2, 2022 that will close this issue
@mty22 mty22 removed a link to a pull request Feb 2, 2022
@mty22
Copy link
Owner

mty22 commented Feb 6, 2022

added to https://github.com/mty22/krunker.io-translations/blob/main/KNOWN_ISSUES.md

@mty22
Copy link
Owner

mty22 commented Feb 9, 2022

This is confirmed, and won't be changed anytime soon.

the {1} variable also may appear as:
on X (map)
with X Weapon (gun)

@mty22 mty22 closed this as completed Feb 9, 2022
@Hiro527 Hiro527 mentioned this issue Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar-issues grammar issues high-priority High Priority
Projects
None yet
Development

No branches or pull requests

3 participants