Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net Standard 2.0 #9

Closed
Nico04 opened this issue May 8, 2018 · 8 comments
Closed

.Net Standard 2.0 #9

Nico04 opened this issue May 8, 2018 · 8 comments

Comments

@Nico04
Copy link

Nico04 commented May 8, 2018

Is it possible to target .NetStandard please ?

@muak
Copy link
Owner

muak commented May 9, 2018

@Nico04

In case .NETStandard <= 1.6, If you write like the following in project.json, it is possible.

https://github.com/muak/Prism.Forms.SampleBase/blob/16ffaf86023943fbf95e12083b6cc5fd64bb28d8/Sample/project.json#L20

Also, I have the plan that I will make this library correspond to NETStandard.

@Nico04
Copy link
Author

Nico04 commented May 9, 2018

Thank you for your answer.
Actually Visual Studio allow your library to be used in .NetStandard project but leaves a warning saying package was restored and may not be fully compatible.
So it's not a real problem as the library seems to works fine this way, it's just an improvement request.
Thanks again for your work

@muak
Copy link
Owner

muak commented May 9, 2018

@Nico04

I am glad to have worked it.
I accepted your request.

Thank you.

@muak muak closed this as completed May 9, 2018
@Nico04
Copy link
Author

Nico04 commented May 10, 2018

More informations on the warning :

warning NU1701: Package 'Xamarin.Plugin.ImageEdit 0.1.0' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.

@Nico04
Copy link
Author

Nico04 commented Jun 21, 2018

I'm glad you accepted my request, do you have any idea when will you update your package @muak ?
Thanks !

@Nico04
Copy link
Author

Nico04 commented Sep 12, 2018

@muak any update on this please ?

@muak
Copy link
Owner

muak commented Sep 19, 2018

@Nico04

I'm sorry for keeping you waiting.
I can't update because I'm busy with work.
I will put this update into the practice by end of this year.

@Nico04
Copy link
Author

Nico04 commented Oct 25, 2018

Thank you for your update !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants