Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordRTC overwrites the browser Storage interface #854

Open
graemechapman opened this issue Oct 5, 2023 · 0 comments
Open

RecordRTC overwrites the browser Storage interface #854

graemechapman opened this issue Oct 5, 2023 · 0 comments

Comments

@graemechapman
Copy link

This library overwrites the browser's existing Storage interface (https://developer.mozilla.org/en-US/docs/Web/API/Storage) with an object which does not conform to this spec - see

var Storage = {};

This can cause unexpected errors in other code present on the page which is working with local/session storage, e.g.

window.localStorage instanceof Storage

This should probably be renamed to something which does not conflict with browser built ins, and also scoped within a function to avoid polluting the global context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant