Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[languages chart] show other languages merged as “other” #588

Closed
tippfehlr opened this issue Jan 6, 2024 · 7 comments
Closed

[languages chart] show other languages merged as “other” #588

tippfehlr opened this issue Jan 6, 2024 · 7 comments

Comments

@tippfehlr
Copy link

Right now, unless the number of languages displayed is set to the max, the percentage of languages is wrong.

This would suggest I only coded in Typescript:
image

But in reality, Typescript is less than half of my time coding.
image

Proposed change:
merge other languages into “other”
Screenshot_20240106_125349

@muety
Copy link
Owner

muety commented Jan 6, 2024

Hi @tippfehlr, thanks for bringing this up. But, frankly, I don't see much of a benefit in the solution you proposed. The way I interpret the functionality is: when decrementing the number of languages shown (e.g. to 5), you're saying "give me my top 5 languages" and among those top five, every language has its respective percentage, regardless of the overall, global coding time. If you opt to only show one language, you're requesting your "top 1 languages", and among those, TypeScript has a share of 100 %.

@tippfehlr
Copy link
Author

Sure, but I don't get the reason to show the percentage of the top language in relation to only the top two languages.

Maybe a switch next to the languages number that toggles this on or off? (eg. relative to total)

@tippfehlr
Copy link
Author

I would like to implement this and learn go a bit on the way, and I guess this wouldn't be too hard. What do you think?

@muety
Copy link
Owner

muety commented Jan 6, 2024

Sure, but I don't get the reason to show the percentage of the top language in relation to only the top two languages.

Fair point, but I don't get the reason for showing some languages in comparison to "other" vs. showing them in comparison to the actual languages either. The only "benefit" would be the pie chart looking less "busy", or am I missing something here?

@tippfehlr
Copy link
Author

tippfehlr commented Jan 6, 2024

The only "benefit" would be the pie chart looking less "busy"

This, and especially the text to the right.

I think having the option to keep them in one column (but still relative to all) might be good.

EDIT: By default, at least for me, Wakapi only displays one column. I would still expect that the relative time is correct. Also, an indicator that there were more languages would be neat I think.

@muety
Copy link
Owner

muety commented Jan 7, 2024

Definitely agree that there should be a hint indicating that there are more languages to show, perhaps alongside a (very small and subtle) show all button or icon. But would like to keep the "filtering" mechanism as is.

@muety muety closed this as completed in e70cc59 Jan 12, 2024
@tippfehlr
Copy link
Author

Thanks <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants