Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few keys in CompletionItem violate the protocol #7

Closed
rwols opened this issue May 13, 2020 · 2 comments
Closed

A few keys in CompletionItem violate the protocol #7

rwols opened this issue May 13, 2020 · 2 comments

Comments

@rwols
Copy link

rwols commented May 13, 2020

Some keys in the returned completion items have a null value. For example:

{
    "label": "__bool__",
    "deprecated": false,
    "documentation": "self != 0",
    "command": null,
    "textEdit": {
        "newText": "__bool__",
        "range": {
            "end": {
                "character": 18,
                "line": 237
            },
            "start": {
                "character": 18,
                "line": 237
            }
        }
    },
    "preselect": false,
    "detail": null,
    "data": null,
    "commitCharacters": null,
    "kind": 18,
    "sortText": "zz__bool__",
    "insertTextFormat": null,
    "additionalTextEdits": null,
    "filterText": null,
    "insertText": null
}

This isn't allowed by the spec. Either the key exists and the value is valid, or the key doesn't exist.

@muffinmad
Copy link
Owner

Created openlawlibrary/pygls#124

@muffinmad
Copy link
Owner

Looks like it is fixed upstream. Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants