-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Prefix all public API to fit into the global Material-UI namespace #1069
Conversation
Actually, I might have approved too quickly. Did you update the markdown in the documentation? Sometimes we mention the exported types. |
I did my best to try and change the names everywhere but there is a possibility that I missed updating somewhere. I checked the docs and it seem correct but if you can click through them as well that would be great. |
@DanailH Here is an example: https://deploy-preview-1069--material-ui-x.netlify.app/components/data-grid/getting-started/#define-rows. |
Ok, I'll go page by page to check what I missed and update it. |
Ok, apparently I missed the definitions and interfaces so I renamed them as well. In the process I also checked the docs - seem to be updated as well. Please give them a quick as well. |
the code should just not compiled if you missed anything. This is why we use typescript |
@dtassone From what I understand |
Not sure what you mean. If you forgot to rename |
Ok, I'm merging this. If something was missed I'll create follow-up PRs to fix it. |
I have updated the migration table with:
|
Breaking changes
Fixes #169
I apologize for the size of the PR 🤐 but I did update all of the public APIs.