Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: rename button variants to follow the spec #11284

Closed
1 task done
yuchi opened this issue May 8, 2018 · 6 comments
Closed
1 task done

Proposal: rename button variants to follow the spec #11284

yuchi opened this issue May 8, 2018 · 6 comments
Labels
breaking change component: button This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process umbrella For grouping multiple issues to provide a holistic view
Milestone

Comments

@yuchi
Copy link
Contributor

yuchi commented May 8, 2018

Material Guidelines changed the name of buttons’ variants. I’m proposing to update the variants name to follow the spec and implement those that are missing.

The rosetta stone is:

Material UI Beta 45 Current API Material Guidelines Proposed API
Flat Button variant="flat" Text Button variant="text"
N/A N/A Outlined Button variant="outlined
Raised Button variant="raised" Contained Button variant="contained"
N/A N/A Toggle Button toggled variant="outlined"

I’m not proposing a specific variant for Toggle Buttons because demos present them as button bars (hence could be a good idea have a specific component) where they are mostly outlined buttons with an additional toggled state, or Icon Buttons with different icons based on the state.

  • I have searched the issues of this repository and believe that this is not a duplicate.
@oliviertassinari oliviertassinari added this to the v2 milestone May 8, 2018
@oliviertassinari oliviertassinari added design: material This is about Material Design, please involve a visual or UX designer in the process component: button This is the name of the generic UI component, not the React module! labels May 8, 2018
@oliviertassinari oliviertassinari added the umbrella For grouping multiple issues to provide a holistic view label May 12, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 18, 2018

@mbrookes I'm not 💯% up-to-date with the latest improvements you did on this topic. Have we moved forward? At least, I know we gonna have to deprecate and remove the API at some point.

@gunn4r
Copy link

gunn4r commented Jun 25, 2018

@oliviertassinari
Copy link
Member

@gunn4r Can you find it in the official specificiation?

@gunn4r
Copy link

gunn4r commented Jun 26, 2018

@oliviertassinari
Yeah I'm not seeing a reference to it here:
https://material.io/design/components/buttons.html

But you do find it in their official Design and API documentation:
https://material.io/develop/web/components/buttons/#variants

As well as their official button demo here:
https://material-components.github.io/material-components-web-catalog/#/component/button

@mbrookes
Copy link
Member

I suggest we stick with the spec names, rather than what the MCW team are using.

@eps1lon
Copy link
Member

eps1lon commented Oct 7, 2018

Legacy variant names will be deprecated with 3.2.0 i.e. deprecation warnings will be logged. The flat and raised variants were already mapped to text and contained respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: button This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

No branches or pull requests

5 participants