Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix the sorted table demo size #10876

Closed
wants to merge 1 commit into from

Conversation

leMaik
Copy link
Member

@leMaik leMaik commented Apr 1, 2018

Via #10871 (comment)

Before:
image

After:
image

I think that a minimum width of 750px is still reasonable for this demo.

@leMaik leMaik added the docs Improvements or additions to the documentation label Apr 1, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 1, 2018

I don't follow. The point of the previous value was to show the table can scroll. With this change, the label collapse:
capture d ecran 2018-04-01 a 18 14 35
Maybe we should increase the value and not decrease it?

@leMaik
Copy link
Member Author

leMaik commented Apr 1, 2018

Maybe we should not make the pagination scroll horzontally. 😄 That would actually fix this.

Oh, and maybe there should be a comment on why there is a minWidth set, so that people don't think it's a bug. 😄

@leMaik leMaik closed this Apr 1, 2018
@leMaik leMaik deleted the fix-table-width branch April 1, 2018 16:21
@oliviertassinari
Copy link
Member

Maybe we should not make the pagination scroll horzontally. 😄 That would actually fix this.

Oh yes, possibly :). The comment sounds like a great idea too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants