Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Showcase] Add posters galore (react-admin) #11939

Merged
merged 5 commits into from
Jun 22, 2018
Merged

[Showcase] Add posters galore (react-admin) #11939

merged 5 commits into from
Jun 22, 2018

Conversation

fzaninotto
Copy link
Contributor

I think that's a good showcase of what material-ui can do.

Thanks for the great work! ❤️

posters-galore

@mbrookes
Copy link
Member

Hi, thanks for the submission.

Please could you make the image 900 x 650, JPEG @ 40% quality to be consistent with the other entries?

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jun 21, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 21, 2018

@fzaninotto Looks good!
@mbrookes I agree a <100 kB image is acceptable, 7.29 MB is not compounded to x20 showcases.

@fzaninotto
Copy link
Contributor Author

As you see fit, I made the changes.

I too think that 7MB per picture is too much if there are more than 20, but I think that the solution is otherwise. The screenshots are too big IMO. The showcase page is so tall that I get tired of scrolling before I get to the half.

I think this page would really benefit from smaller screenshots, allowing 2 to 4 screenshots per row. Not only would it show more sites to users with less effort, it would allow gifs instead of only jpg. And considering Material Design is really into microanimations, I do think that a gif sells more than a still picture.

Lastly, maybe the appList could have both an image and a video link, the video being lazy loaded when the image is on screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants