[Snackbar] Add check for autoHideDuration if equals 0 #12002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@C-Rodg Could you add a unit test? Thanks :) |
oliviertassinari
added
bug 🐛
|
@oliviertassinari unit test has been added! |
|
@C-Rodg It's perfect 👌 , you rock 🎸 . |
acroyear
pushed a commit
to acroyear/material-ui
that referenced
this pull request
Jul 14, 2018
* Add check for snackbar autoHideDuration if equals 0 * Add unit test for resumeHideDuration equaling zero * fix anothre potential issue
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I've added a check to prevent the Snackbar component from using the autoHideDuration property if a '0' is passed in. This fixes #11946.
Thanks!