Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExpansionPanelSummary] Add IconButtonProps property #12035

Merged
merged 4 commits into from
Jul 2, 2018

Conversation

dakotamurphyucf
Copy link
Contributor

Purpose

Add expandIconProps property to ExpantionPanelSummary component.
Right now there is no way to do things like disable the ripple for the expand Icon.

        <ExpansionPanel >
          <ExpansionPanelSummary expandIcon={<ExpandMoreIcon />} expandIconProps={{ disableRipple: true }}>
                    <Typography className={classes.heading}>General settings</Typography>
                    <Typography className={classes.secondaryHeading}>I am an expansion panel</Typography>
            </ExpansionPanelSummary>
            <ExpansionPanelDetails>
                <Typography>
                  Nulla facilisi. Phasellus sollicitudin nulla et quam mattis feugiat. Aliquam eget
                  maximus est, id dignissim quam.
                </Typography>
          </ExpansionPanelDetails>
        </ExpansionPanel>

@oliviertassinari oliviertassinari self-assigned this Jul 2, 2018
@oliviertassinari oliviertassinari changed the title add expandIcon Props [ExpansionPanelSummary] Add IconButtonProps property Jul 2, 2018
@oliviertassinari oliviertassinari merged commit 06bac3e into mui:master Jul 2, 2018
@oliviertassinari
Copy link
Member

@dakotamurphyucf Thank you

@oliviertassinari oliviertassinari added new feature New feature or request component: accordion This is the name of the generic UI component, not the React module! labels Jul 2, 2018
@dakotamurphyucf dakotamurphyucf deleted the add-expandIconProps branch July 2, 2018 20:12
acroyear pushed a commit to acroyear/material-ui that referenced this pull request Jul 14, 2018
* add expandIcon Props

* fix lint-issues

* add @ignore

* rename IconButtonProps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: accordion This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants