Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tab] Fix maxWidth issue with fullWidth mode #12158

Merged
merged 2 commits into from
Jul 15, 2018
Merged

[Tab] Fix maxWidth issue with fullWidth mode #12158

merged 2 commits into from
Jul 15, 2018

Conversation

chenop
Copy link
Contributor

@chenop chenop commented Jul 15, 2018 •
edited by oliviertassinari
Loading

Closes #11947

@mbrookes
Copy link
Member

@chenop What's the motivation for this change?

@oliviertassinari oliviertassinari added the component: tabs This is the name of the generic UI component, not the React module! label Jul 15, 2018
@oliviertassinari oliviertassinari changed the title Removed maxWidth:264 constraint [Tab] Fix maxWidth issue with fullWidth mode Jul 15, 2018
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jul 15, 2018
@oliviertassinari oliviertassinari self-assigned this Jul 15, 2018
@oliviertassinari oliviertassinari merged commit 7562658 into mui:master Jul 15, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 15, 2018 •
edited
Loading

@chenop Thanks
@mbrookes I have linked the related issue in the description. It's about making the full width being predictable.

@chenop chenop deleted the 11947-Tabs-fullWidth-inconsistent-with-default-CSS branch July 16, 2018 08:06
@jankjr
Copy link
Contributor

jankjr commented Aug 13, 2018 •
edited
Loading

auto is not a valid value for max-width

Source:
https://developer.mozilla.org/en-US/docs/Web/CSS/max-width

max-width: 100% yields the expected behaviour.

@jankjr
Copy link
Contributor

jankjr commented Aug 13, 2018

#12495

@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
This was referenced Mar 26, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

@oliviertassinari oliviertassinari

Labels
bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenop @mbrookes @oliviertassinari @jankjr