Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix escape "|" char #12254

Merged
merged 3 commits into from
Jul 24, 2018
Merged

[docs] Fix escape "|" char #12254

merged 3 commits into from
Jul 24, 2018

Conversation

TheRusskiy
Copy link
Contributor

at the moment | char is unescaped which messes up formatting

@mbrookes
Copy link
Member

Good catch! But to fix it you'll need to edit the comment in the component and run yarn docs:api or npm run docs:api.

@TheRusskiy
Copy link
Contributor Author

@mbrookes oh, sorry!
gonna do that a bit later

@oliviertassinari oliviertassinari changed the title Docs fix: escape "|" char [docs] Fix escape "|" char Jul 23, 2018
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 23, 2018
@@ -47,18 +47,18 @@ This property accepts the following keys:
| <span class="prop-name">flatPrimary</span> | Styles applied to the root element for backwards compatibility with legacy variant naming.
| <span class="prop-name">flatSecondary</span> | Styles applied to the root element for backwards compatibility with legacy variant naming.
| <span class="prop-name">outlined</span> | Styles applied to the root element if `variant="outlined"`.
| <span class="prop-name">contained</span> | Styles applied to the root element if `variant="[contained \| fab]"`.
| <span class="prop-name">containedPrimary</span> | Styles applied to the root element if `variant="[contained \| fab]"` and `color="primary"`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we lost a closing bracket?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on this if you don't mind 👼

@oliviertassinari oliviertassinari self-assigned this Jul 24, 2018
@TheRusskiy
Copy link
Contributor Author

@oliviertassinari fyi this escape seems to not be working: https://cl.ly/2w140H3o1S0p
so I ended up escaping values "manually"

@oliviertassinari
Copy link
Member

@TheRusskiy Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants