Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DialogContentText] Inherit TypographyProps in type definition #12301

Merged
merged 1 commit into from
Jul 27, 2018
Merged

[DialogContentText] Inherit TypographyProps in type definition #12301

merged 1 commit into from
Jul 27, 2018

Conversation

ctdio
Copy link
Contributor

@ctdio ctdio commented Jul 27, 2018

The docs specify that for the DialogContentText component:

Any other properties supplied will be spread to the root element (Typography).

This is true in practice, but the typings for the component does not support that statement. This PR allows for the DialogContentTextProps type to inherit properties from the TypographyProps type.

@oliviertassinari oliviertassinari added component: dialog This is the name of the generic UI component, not the React module! typescript labels Jul 27, 2018
@oliviertassinari oliviertassinari merged commit f432f8a into mui:master Jul 27, 2018
@oliviertassinari
Copy link
Member

@charlieduong94 It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot!

@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
This was referenced Mar 26, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctdio @oliviertassinari