Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip] Add default css max-width and customization demo #12338

Merged
merged 3 commits into from
Jul 30, 2018

Conversation

simoami
Copy link
Contributor

@simoami simoami commented Jul 30, 2018

Take 2: Max Width as pure css default.

@simoami simoami changed the title Add default css max-width and customization demo. Add default css max-width and customization demo Jul 30, 2018
@simoami simoami changed the title Add default css max-width and customization demo [Tooltip] Add default css max-width and customization demo Jul 30, 2018
return (
<div>
<Tooltip title={longText}>
<Button className={classes.button}>Default Width</Button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to mention what the default width is in the button text?

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@oliviertassinari oliviertassinari added component: tooltip This is the name of the generic UI component, not the React module! new feature New feature or request labels Jul 30, 2018
@mbrookes mbrookes merged commit bfc0acb into mui:master Jul 30, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 30, 2018

@simoami You have done a great job.

@simoami
Copy link
Contributor Author

simoami commented Jul 30, 2018

Thanks @oliviertassinari 👍 I'll be happy to contribute more once I get a chance. Thanks to both of you for your insight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tooltip This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants