[Step] Add completed class to the root #12339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
added
new feature
mbrookes
approved these changes
Jul 30, 2018
|
@kylezinter It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot! |
|
Thanks for all the work you guys have put into it, @oliviertassinari, hope I can contribute more! |
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only place a completed class is being placed in the Step component is deep on the svg element, the MuiSvgIcon of the MuiStepLabel. Adding a class at the root level allows the developer to style any aspect of the Step component when the step is completed. The specific example I've been using this for is to style the step connector and provide and line animation into the next label.