Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip] Fix autoFocus issue #12372

Merged
merged 2 commits into from
Aug 2, 2018
Merged

Conversation

Mangatt
Copy link
Contributor

@Mangatt Mangatt commented Aug 2, 2018

Closes #12371.

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 2, 2018

I'm closing as I doubt the existiance of such issue in the first place, please provide a reproduction, or even better, a failing test case.

@Mangatt
Copy link
Contributor Author

Mangatt commented Aug 2, 2018

It definitely exists :)

@Mangatt
Copy link
Contributor Author

Mangatt commented Aug 2, 2018

You can try to remove autoFocus prop and voilá, everything is working again.

@oliviertassinari
Copy link
Member

I was able to reproduce, thanks :). I still need to figure out what's going on. I would rather have as few defensive logic as possible. Try to cure the root cause.

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 2, 2018

Ok, this fix is hiding the problem. We need to use a setTimeout logic before running the handleEnter method so the tooltip is shown when the input is auto focus.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module! labels Aug 2, 2018
@oliviertassinari oliviertassinari changed the title [Tooltip] childrenRef [Tooltip] Fix autoFocus issue Aug 2, 2018
@oliviertassinari oliviertassinari force-pushed the Contributing branch 3 times, most recently from f120cf0 to 6a32962 Compare August 2, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants