Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add example layouts #12410

Merged
merged 21 commits into from
Aug 5, 2018
Merged

[docs] Add example layouts #12410

merged 21 commits into from
Aug 5, 2018

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Aug 4, 2018

Closes #10986

screenshot_2018-08-04 layouts - material-ui

@oliviertassinari oliviertassinari added new feature New feature or request docs Improvements or additions to the documentation labels Aug 4, 2018
@oliviertassinari oliviertassinari self-assigned this Aug 4, 2018
@oliviertassinari oliviertassinari merged commit 876cc40 into mui:master Aug 5, 2018
@benneq
Copy link
Contributor

benneq commented Aug 13, 2018

Great work! Finally I can copy & paste nice working design examples! :)

I found one minor issue within the Dashboard example: https://material-ui.com/page-layout-examples/dashboard/

When you make your browser windows small, the Toolbar and Drawer use the dense appearance. But the padding of the Menu Button within the Toolbar won't adapt.

I'm no CSS expert, but I guess that it should become margin-left: 4px when dense layout is active.

The Toolbar's padding-right may need some adjustment, too.


Another nice feature request would be to exchange the Drawer variant on smaller screens. Something like:

<Hidden mdUp={true}>
    <Drawer variant="temporary">
        ...
    </Drawer>
</Hidden>
<Hidden smDown={true}>
    <Drawer variant="permanent">
        ...
    </Drawer>
</Hidden>

And then accordingly use some slightly different CSS. For example remove the padding from content (or make it much smaller).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants