-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Table] Padding feature #12415
Merged
Merged
[Table] Padding feature #12415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
PR: needs revision
The pull request can't be merged. More details is available on the code review or fails in the CI
component: table
This is the name of the generic UI component, not the React module!
labels
Aug 5, 2018
Fixed omission of padding as a valid prop of Table. Fixed read-only problems with padding. Defined Padding.
oliviertassinari
added
new feature
New feature or request
and removed
PR: needs revision
The pull request can't be merged. More details is available on the code review or fails in the CI
labels
Aug 7, 2018
oliviertassinari
force-pushed
the
tablefix
branch
from
August 7, 2018 21:00
baeaf73
to
53a528d
Compare
@aseem191 thanks |
hmmmm, seems like a typescript definition leak here. I'll go fix this. |
franklixuefei
added a commit
to franklixuefei/material-ui
that referenced
this pull request
Aug 13, 2018
Merged
oliviertassinari
pushed a commit
that referenced
this pull request
Aug 13, 2018
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: table
This is the name of the generic UI component, not the React module!
new feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a fix/addition for #12162, which adds a padding prop to Table, which allows TableCells to inherit the padding of the Table, but override if necessary.
Closes #12162