Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Save some bytes in the super() logic #12476

Merged

Conversation

oliviertassinari
Copy link
Member

Calling super with the props is allowing us to use this.props in the constructor. By avoiding this pattern, we can reduce the bundle size.

    constructor(props) {
      super(props);

@oliviertassinari oliviertassinari changed the title [core] Same some bytes in the super() logic [core] Save some bytes in the super() logic Aug 11, 2018
@oliviertassinari oliviertassinari force-pushed the core-super-save-some-bytes branch 3 times, most recently from 6660606 to e74884b Compare August 11, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants