Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] "codestyle" comment typo fix #12511

Merged
merged 4 commits into from
Aug 14, 2018
Merged

Conversation

nicksiscoe
Copy link
Contributor

for consistency with other descriptions

@mbrookes
Copy link
Member

Sorry, but I don't understand the purpose of this PR - it seems to simple add a line-break (which isn't currently supported in the style descriptions IIRC).

@nicksiscoe
Copy link
Contributor Author

nicksiscoe commented Aug 14, 2018

line-break wasn't intended, just reverted that. The purpose of the PR is just a quick fix for displaying one piece of text as code that should've been formatted as code in the first place but currently isn't.

Currently having an issue with lint on the line length though, that's why I broke the line mistakenly originally.

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 14, 2018

I don't understand the purpose of this PR

@mbrookes I believe it's the following:

capture d ecran 2018-08-14 a 21 03 59

@oliviertassinari oliviertassinari changed the title "codestyle" comment typo fix [docs] "codestyle" comment typo fix Aug 14, 2018
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Aug 14, 2018
@mbrookes
Copy link
Member

Ah, thanks both, I didn't spot the back-ticks in the PR, may bad. (My excuse is that it was late! 😪 😄).

I guess you could add an eslint-disable-next-line before it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants