Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Divider] Remove deprecated inset prop #14826

Merged

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding commented Mar 10, 2019

Removes the deprecated Divider inset prop

Breaking change

-<Divider inset />
+<Divider variant="inset" />

@joshwooding joshwooding added breaking change component: divider This is the name of the generic UI component, not the React module! labels Mar 10, 2019
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: a5b8011...1a39c22

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.01% -0.01% 362,777 362,756 92,213 92,205
@material-ui/core/Paper 0.00% 0.00% 68,878 68,878 20,170 20,170
@material-ui/core/Paper.esm 0.00% 0.00% 63,340 63,340 19,272 19,272
@material-ui/core/Popper 0.00% 0.00% 30,460 30,460 10,573 10,573
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,284 17,284 5,700 5,700
@material-ui/core/useMediaQuery 0.00% 0.00% 2,471 2,471 1,035 1,035
@material-ui/lab 0.00% 0.00% 170,747 170,747 50,065 50,065
@material-ui/styles 0.00% 0.00% 57,220 57,220 16,273 16,273
@material-ui/system 0.00% 0.00% 17,041 17,041 4,493 4,493
Button 0.00% 0.00% 91,152 91,152 26,939 26,939
Modal 0.00% 0.00% 90,261 90,261 26,724 26,724
colorManipulator 0.00% 0.00% 3,232 3,232 1,298 1,298
docs.landing 0.00% 0.00% 51,908 51,908 11,302 11,302
docs.main -0.01% -0.00% 647,808 647,775 201,557 201,548
packages/material-ui/build/umd/material-ui.production.min.js -0.01% -0.01% 311,179 311,158 85,197 85,189

Generated by 🚫 dangerJS against 1a39c22

@eps1lon eps1lon mentioned this pull request Mar 10, 2019
56 tasks
@oliviertassinari oliviertassinari merged commit 5ae95b8 into mui:next Mar 11, 2019
@joshwooding joshwooding deleted the remove-deprecated-divider-inset-prop branch March 11, 2019 07:43
@oliviertassinari oliviertassinari changed the title [Divider] Remove Divider inset prop [Divider] Remove deprecated inset prop Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: divider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants