Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Remove the support for a rare edge-case #14995

Closed

Conversation

oliviertassinari
Copy link
Member

Breaking change

You should control the text field component either at the TextField (FormControl) level or at the InputBase (Input, FilledInput, OutlinedInput) level. Don't mix the two approaches.

@oliviertassinari oliviertassinari added breaking change component: text field This is the name of the generic UI component, not the React module! labels Mar 21, 2019
@eps1lon eps1lon mentioned this pull request Mar 21, 2019
56 tasks
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: d1a7d76...109f1ab

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.03% -0.02% 352,929 352,835 90,642 90,624
@material-ui/core/Paper 0.00% 0.00% 68,626 68,626 19,974 19,974
@material-ui/core/Paper.esm 0.00% 0.00% 62,358 62,358 19,075 19,075
@material-ui/core/Popper 0.00% 0.00% 30,460 30,460 10,528 10,528
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,384 17,384 5,726 5,726
@material-ui/core/useMediaQuery 0.00% 0.00% 2,469 2,469 1,037 1,037
@material-ui/lab 0.00% 0.00% 152,181 152,181 44,533 44,533
@material-ui/styles 0.00% 0.00% 53,837 53,837 15,613 15,613
@material-ui/system 0.00% 0.00% 17,138 17,138 4,520 4,520
Button 0.00% 0.00% 90,918 90,918 26,970 26,970
Modal 0.00% 0.00% 84,712 84,712 25,262 25,262
colorManipulator 0.00% 0.00% 3,232 3,232 1,300 1,300
docs.landing 0.00% 0.00% 51,843 51,843 11,349 11,349
docs.main -0.01% -0.01% 647,762 647,668 201,135 201,118
packages/material-ui/build/umd/material-ui.production.min.js -0.03% -0.02% 301,958 301,864 83,730 83,712

Generated by 🚫 dangerJS against 109f1ab

@eps1lon
Copy link
Member

eps1lon commented Mar 21, 2019

I'm a little bit confused. That particular code is concerned with the focus in context when the input becomes disabled.

There is still plenty of code that calls back to the context if props changes. I'd be happy to remove every context vs. props logic. Only removing some parts will lead to confusion I fear.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Mar 21, 2019

@eps1lon I see what you mean. Yes, this change is completely wrong. I would rather ignore the concern for v4. I think that we can close the pull request.

@oliviertassinari oliviertassinari deleted the text-field-simpler-logic branch February 8, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants