Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextareaAutoSize] Add ref prop #17835

Merged
merged 2 commits into from
Oct 14, 2019
Merged

[TextareaAutoSize] Add ref prop #17835

merged 2 commits into from
Oct 14, 2019

Conversation

Tarun047
Copy link
Contributor

@Tarun047 Tarun047 commented Oct 11, 2019

Edit @eps1lon:
Adjusted PR reference so that github recognizes that this PR closes an issue.

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 11, 2019

No bundle size changes comparing 0f968fc...2b02ce8

Generated by 🚫 dangerJS against 2b02ce8

@Tarun047
Copy link
Contributor Author

@oliviertassinari I have made a PR following your comment.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. I think we can simplify this a bit.

@eps1lon eps1lon changed the title Fix property ref for TextareaAutoSize [TextareaAutoSize] Add ref prop Oct 11, 2019
Co-Authored-By: Sebastian Silbermann <silbermann.sebastian@gmail.com>
@Tarun047
Copy link
Contributor Author

@eps1lon
Thanks for your suggestion, I have made the changes and simplified the code

@Tarun047 Tarun047 requested a review from eps1lon October 11, 2019 06:28
@oliviertassinari
Copy link
Member

Should we handle ClickAwayListener and Portal too?

@eps1lon eps1lon merged commit 91ac578 into mui:master Oct 14, 2019
@eps1lon
Copy link
Member

eps1lon commented Oct 14, 2019

@Tarun047 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TextareaAutosize] Property 'ref' does not exist on type
4 participants