-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Prevent layout shift when rendering ads #17893
Conversation
Details of bundle changes.Comparing: 0f28b62...1fa6b5c
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1fa6b5c:
|
I will follow up to solve an edge case, we don't display the ad on all the pages, for instance, it's excluded from the installation page. |
I see, I guess the style rules should rather go in here, conditionally based on the |
What do you think of this solution 1fa6b5c? |
Ok for me |
Thank you for taking the time |
@oliviertassinari 👍 Ok, that works well, I've turned my adblocker off. |
I have created a reminder in 2 months, I'm curious to see how the click/display and user/display metric evolves.
This means an extra ~$0.03 for us at the end of the months. Thanks 😁. |
Fixes #17887