Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve fixed app bar placement section #17896

Conversation

adeelibr
Copy link
Contributor

@adeelibr adeelibr commented Oct 15, 2019

This PR builds on improvements suggested in #17878

Closes #16844

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 15, 2019

No bundle size changes comparing ec7b5e9...6bf3bc9

Generated by 🚫 dangerJS against 6bf3bc9

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 15, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6bf3bc9:

Sandbox Source
create-react-app Configuration
create-react-app-with-typescript Configuration

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up pull request. In:

    <div>
      <Appbar position="fixed"></Appbar>
      <div className={classes.offset}> {/* to accomdate for top white space */}
    </div>

You can fix the syntax and apply our style convention.

docs/src/pages/components/app-bar/app-bar.md Outdated Show resolved Hide resolved
docs/src/pages/components/app-bar/app-bar.md Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Oct 16, 2019
@adeelibr
Copy link
Contributor Author

I have made the changes, can you kindly review :)

@oliviertassinari oliviertassinari changed the title [docs] document placement section of Appbar for variant fixed [docs] Improve fixed app bar placement section Oct 16, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates. I have added a new commit, it was faster for me. Let me know what you think.

@adeelibr
Copy link
Contributor Author

I think it is awesome now 👍👍👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppBar offset component when it's fixed
3 participants