Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Document how values are compared #17912

Merged
merged 4 commits into from
Oct 18, 2019
Merged

[Select] Document how values are compared #17912

merged 4 commits into from
Oct 18, 2019

Conversation

DustinRobison
Copy link

@DustinRobison DustinRobison commented Oct 17, 2019 •
edited by oliviertassinari
Loading

Closes #17764

@codesandbox-ci

This comment has been minimized.

Sign in to view
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 17, 2019 •
edited
Loading

No bundle size changes comparing 5d564f9...128f046

Generated by 🚫 dangerJS against 128f046

eps1lon
eps1lon previously requested changes Oct 17, 2019
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for documenting this. Unfortunately it's a bit more complicate.

Code for reference:
https://github.com/mui-org/material-ui/blob/3a64d1729425a9ea927125533f23009796ba2b06/packages/material-ui/src/Select/SelectInput.js#L10-L16

packages/material-ui/src/Select/Select.js Outdated Show resolved Hide resolved
@eps1lon eps1lon changed the title Select docs value to options reference equality comparison [Select] Document how values are compared Oct 17, 2019
@eps1lon eps1lon added component: select This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Oct 17, 2019
@oliviertassinari oliviertassinari merged commit 0a6d9a5 into mui:master Oct 18, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 18, 2019 •
edited
Loading

@DustinRobison Thank you!

@DustinRobison DustinRobison deleted the docs/Update-select-docs-refernce-equality-check branch October 21, 2019 16:00
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: select This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select] The value matches with reference equality, document it
4 participants
@DustinRobison @mui-pr-bot @oliviertassinari @eps1lon