[docs] Replace negative actions from fab examples #17926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 0a6d9a5...087becb |
There was a problem hiding this comment.
I can find the following mention: Use FABs for primary, positive actions..
I think that we can move forward with the changes. However, could you update the TypeScript verison of the demos? (yarn docs:typescript:formatted to generate the JavaScript version). Thanks
|
Sure, will do it in a few minutes, thanks! |
nuragic
force-pushed
the
remove-negative-actions-fab
branch
from
9c3726e
to
087becb
Compare
|
Done! |
oliviertassinari
approved these changes
Oct 18, 2019
joshwooding
approved these changes
Oct 18, 2019
|
@nuragic Thanks, it's a great first contribution to Material-UI 🎉 |
|
Oh well, thank you! 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Per spec, negative actions such as remove or delete cannot appear in FAB:
https://material.io/components/buttons-floating-action-button/#behavior
Thanks!