Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Reduce ByRole calls #18015

Merged
merged 1 commit into from
Oct 24, 2019
Merged

[test] Reduce ByRole calls #18015

merged 1 commit into from
Oct 24, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 24, 2019

ask not what your dependency can do for you — ask what you can do for your dependency.

-- John F. Kennedy's Inaugural Address, January 20, 1961

@mui-pr-bot
Copy link

No bundle size changes comparing 7f870e6...894dca2

Generated by 🚫 dangerJS against 894dca2

@oliviertassinari
Copy link
Member

Looking at a diff between 2 runs, I observe a drop from 43 seconds on the CI down to 33 seconds. It's pretty cool ✌️!

@eps1lon eps1lon merged commit 41ca73e into mui:master Oct 24, 2019
@eps1lon eps1lon deleted the test/byRole-reduction branch October 24, 2019 09:48
@oliviertassinari oliviertassinari mentioned this pull request Oct 24, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
performance test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari