Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Workaround next.js AMP support limitation #18020

Merged
merged 2 commits into from Oct 24, 2019
Merged

[docs] Workaround next.js AMP support limitation #18020

merged 2 commits into from Oct 24, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2019 •
edited by oliviertassinari
Loading

Closes #17784

@ghost ghost changed the title Apply changes as suggested in issue #17784 [docs] Apply changes as suggested in issue #17784 Oct 24, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing fdafbc5...f649347

Generated by 🚫 dangerJS against f649347

@oliviertassinari oliviertassinari changed the title [docs] Apply changes as suggested in issue #17784 [docs] Workaround next.js AMP support limitation Oct 24, 2019
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Oct 24, 2019
oliviertassinari
oliviertassinari approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm not aware of any limitation of these changes, it should be safe :)

@oliviertassinari oliviertassinari merged commit 2c219b1 into mui:master Oct 24, 2019
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example "nextjs-with-typescript" not working with NextJS AMP support
3 participants
@mui-pr-bot @oliviertassinari @FabianKielmann