Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drawer] Improve "ResponsiveDrawer" demo #18045

Merged
merged 2 commits into from
Oct 29, 2019
Merged

[Drawer] Improve "ResponsiveDrawer" demo #18045

merged 2 commits into from
Oct 29, 2019

Conversation

gorjan-mishevski
Copy link
Contributor

The app bar at the top does not fit the full size of the screen when going mobile. It stays chopped at 240(drawerWidth). and you end up with half the screen empty on mobile. This PR fixes that issue.

The app bar at the top does not fit the full size of the screen when going mobile. It stays chopped at 240(drawerWidth). and you end up with half the screen empty on mobile. This PR fixes that issue.
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 26, 2019

No bundle size changes comparing 7d5d913...62c3c64

Generated by 🚫 dangerJS against 62c3c64

@oliviertassinari oliviertassinari changed the title Update ResponsiveDrawer.tsx [Drawer] Improve "ResponsiveDrawer" demo Oct 29, 2019
@oliviertassinari oliviertassinari added component: drawer This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Oct 29, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted. Yes, it can be an issue if the app bar is not fixed positioned 👍.

@oliviertassinari oliviertassinari merged commit 9a39b3c into mui:master Oct 29, 2019
@oliviertassinari
Copy link
Member

@gorjan-mishevski It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: drawer This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants