[test] Fix tests failing on subsequent runs in watchmode #18076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 9a39b3c...7469dd4 |
| const { getByTestId, getAllByRole, getByRole, queryByRole } = render(<SelectAndDialog />); | ||
| expect(getByRole('button')).to.have.text('Ten'); |
There was a problem hiding this comment.
Should we share the same variable?
Suggested change
| expect(getByRole('button')).to.have.text('Ten'); | |
| expect(trigger).to.have.text('Ten'); |
There was a problem hiding this comment.
That isn't supposed to be there anyway.
oliviertassinari
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use custom
createServerRenderinstead oftest-utils/createRender(which is now deprecated). This allows custom cleanup logic to handleuseLayoutEffectwarnings when using ssr API in a DOM environment. Mocking the React module seems to be lost on repeated runs in watchmode (which was the bulk of the failures).Other issue were due to incomplete cleanup (window.matchMedia stubs) or excessive polling of ByRole in
wait(which we should probably remove but let's wait a bit; edit: only now realized that this was a great pun).I have a feeling that there's something leaking when watching. This might explain why some tests only timed out on subsequent runs.