[docs] Improve TypeScript support of Next.js examples #18088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing e693f95...cd2198a |
oliviertassinari
added
docs
|
I confirm it works with amp, but I had to do these changes: diff --git a/examples/nextjs-with-typescript/pages/_document.tsx b/examples/nextjs-with-typescript/pages/_document.tsx
index 05473eab3..4ac67ac2f 100644
--- a/examples/nextjs-with-typescript/pages/_document.tsx
+++ b/examples/nextjs-with-typescript/pages/_document.tsx
@@ -6,13 +6,9 @@ import theme from '../src/theme';
export default class MyDocument extends Document {
render() {
return (
- <html lang="en">
+ <html lang="en" amp="true">
<Head>
<meta charSet="utf-8" />
- <meta
- name="viewport"
- content="minimum-scale=1, initial-scale=1, width=device-width, shrink-to-fit=no"
- />
{/* PWA primary color */}
<meta name="theme-color" content={theme.palette.primary.main} />
<link
diff --git a/examples/nextjs-with-typescript/pages/index.tsx b/examples/nextjs-with-typescript/pages/index.tsx
index f8993c3dc..fb5cdb933 100644
--- a/examples/nextjs-with-typescript/pages/index.tsx
+++ b/examples/nextjs-with-typescript/pages/index.tsx
@@ -6,6 +6,8 @@ import MuiLink from '@material-ui/core/Link';
import ProTip from '../src/ProTip';
import Link from '../src/Link';
+export const config = { amp: true };
+
function Copyright() {
return (
<Typography variant="body2" color="textSecondary" align="center"> |
oliviertassinari
changed the title
oliviertassinari
approved these changes
Oct 29, 2019
|
@Tokenyet Thank you |
|
@oliviertassinari still facing the same issue when using materialui in AMP pages in nextjs.
|
|
@mufaddal7 Maybe we broke it again, no idea. The support of AMP isn't a priority, could you look into what's wrong and fix it :)? (For v5) |
|
Sure, I can do that. Can you give me a head start or a guide on how you had fixed it last time? @oliviertassinari |
|
@mufaddal7 This pull request is about fixing AMP, it's all the information we have (I believe) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Typescript error for
Closes #18044