Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Fix props based styles callback not including defaultProps #18125

Merged
merged 1 commit into from
Nov 3, 2019
Merged

[styles] Fix props based styles callback not including defaultProps #18125

merged 1 commit into from
Nov 3, 2019

Conversation

salmanm
Copy link
Contributor

@salmanm salmanm commented Oct 31, 2019

Fixes #18124

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 31, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 76376ee...07c4de0

bundle Size Change Size Gzip Change Gzip
LinearProgress ▲ +30 B (+0.05% ) 63.8 kB ▲ +12 B (+0.06% ) 19.9 kB
ListItemSecondaryAction ▲ +30 B (+0.05% ) 60.5 kB ▲ +11 B (+0.06% ) 18.9 kB
TextField ▲ +30 B (+0.02% ) 121 kB ▲ +11 B (+0.03% ) 35.4 kB
CardActions ▲ +30 B (+0.05% ) 60.5 kB ▲ +10 B (+0.05% ) 18.9 kB
Container ▲ +30 B (+0.05% ) 61.6 kB ▲ +10 B (+0.05% ) 19.2 kB
DialogActions ▲ +30 B (+0.05% ) 60.5 kB ▲ +10 B (+0.05% ) 18.9 kB
DialogContent ▲ +30 B (+0.05% ) 60.7 kB ▲ +10 B (+0.05% ) 19 kB
Drawer ▲ +30 B (+0.04% ) 82.7 kB ▲ +10 B (+0.04% ) 25.6 kB
FormGroup ▲ +30 B (+0.05% ) 60.5 kB ▲ +10 B (+0.05% ) 18.9 kB
NativeSelect ▲ +30 B (+0.04% ) 75.2 kB ▲ +10 B (+0.04% ) 23.7 kB
Toolbar ▲ +30 B (+0.05% ) 60.8 kB ▲ +10 B (+0.05% ) 19 kB
@material-ui/core[umd] ▲ +30 B (+0.01% ) 308 kB ▲ +9 B (+0.01% ) 88.7 kB
@material-ui/lab ▲ +30 B (+0.02% ) 168 kB ▲ +9 B (+0.02% ) 50.6 kB
AppBar ▲ +30 B (+0.05% ) 62.2 kB ▲ +9 B (+0.05% ) 19.5 kB
Avatar ▲ +30 B (+0.05% ) 61.1 kB ▲ +9 B (+0.05% ) 19.2 kB
Badge ▲ +30 B (+0.05% ) 63.8 kB ▲ +9 B (+0.05% ) 19.7 kB
BottomNavigation ▲ +30 B (+0.05% ) 60.8 kB ▲ +9 B (+0.05% ) 19 kB
Breadcrumbs ▲ +30 B (+0.05% ) 66.4 kB ▲ +9 B (+0.04% ) 20.8 kB
ButtonGroup ▲ +30 B (+0.05% ) 62.7 kB ▲ +9 B (+0.05% ) 19.5 kB
Card ▲ +30 B (+0.05% ) 61.2 kB ▲ +9 B (+0.05% ) 19.1 kB
CardContent ▲ +30 B (+0.05% ) 60.4 kB ▲ +9 B (+0.05% ) 18.9 kB
CardHeader ▲ +30 B (+0.05% ) 63.5 kB ▲ +9 B (+0.05% ) 20 kB
CardMedia ▲ +30 B (+0.05% ) 60.8 kB ▲ +9 B (+0.05% ) 19.1 kB
CircularProgress ▲ +30 B (+0.05% ) 62.5 kB ▲ +9 B (+0.05% ) 19.7 kB
DialogContentText ▲ +30 B (+0.05% ) 62.5 kB ▲ +9 B (+0.05% ) 19.6 kB
DialogTitle ▲ +30 B (+0.05% ) 62.7 kB ▲ +9 B (+0.05% ) 19.7 kB
Divider ▲ +30 B (+0.05% ) 61 kB ▲ +9 B (+0.05% ) 19.1 kB
ExpansionPanelActions ▲ +30 B (+0.05% ) 60.5 kB ▲ +9 B (+0.05% ) 18.9 kB
ExpansionPanelDetails ▲ +30 B (+0.05% ) 60.4 kB ▲ +9 B (+0.05% ) 18.9 kB
FormControl ▲ +30 B (+0.05% ) 62.8 kB ▲ +9 B (+0.05% ) 19.5 kB
FormControlLabel ▲ +30 B (+0.05% ) 64 kB ▲ +9 B (+0.04% ) 20.1 kB
FormHelperText ▲ +30 B (+0.05% ) 61.7 kB ▲ +9 B (+0.05% ) 19.3 kB
FormLabel ▲ +30 B (+0.05% ) 61.9 kB ▲ +9 B (+0.05% ) 19.1 kB
Grid ▲ +30 B (+0.05% ) 63.5 kB ▲ +9 B (+0.05% ) 19.9 kB
GridList ▲ +30 B (+0.05% ) 60.9 kB ▲ +9 B (+0.05% ) 19.1 kB
GridListTile ▲ +30 B (+0.05% ) 62.2 kB ▲ +9 B (+0.05% ) 19.5 kB
GridListTileBar ▲ +30 B (+0.05% ) 61.7 kB ▲ +9 B (+0.05% ) 19.3 kB
Hidden ▲ +30 B (+0.05% ) 64.5 kB ▲ +9 B (+0.04% ) 20.2 kB
Icon ▲ +30 B (+0.05% ) 61.2 kB ▲ +9 B (+0.05% ) 19.2 kB
InputAdornment ▲ +30 B (+0.05% ) 63.5 kB ▲ +9 B (+0.05% ) 20 kB
InputLabel ▲ +30 B (+0.05% ) 63.8 kB ▲ +9 B (+0.05% ) 19.8 kB
Link ▲ +30 B (+0.05% ) 65 kB ▲ +9 B (+0.04% ) 20.6 kB
List ▲ +30 B (+0.05% ) 60.8 kB ▲ +9 B (+0.05% ) 18.9 kB
ListItemAvatar ▲ +30 B (+0.05% ) 60.6 kB ▲ +9 B (+0.05% ) 18.9 kB
ListItemIcon ▲ +30 B (+0.05% ) 60.6 kB ▲ +9 B (+0.05% ) 19 kB
ListItemText ▲ +30 B (+0.05% ) 63.4 kB ▲ +9 B (+0.05% ) 19.9 kB
ListSubheader ▲ +30 B (+0.05% ) 61.2 kB ▲ +9 B (+0.05% ) 19.2 kB
MobileStepper ▲ +30 B (+0.05% ) 66.2 kB ▲ +9 B (+0.04% ) 20.6 kB
Radio ▲ +30 B (+0.04% ) 80.9 kB ▲ +9 B (+0.04% ) 25.4 kB
RadioGroup ▲ +30 B (+0.05% ) 61.7 kB ▲ +9 B (+0.05% ) 19.3 kB
Rating ▲ +30 B (+0.04% ) 68.3 kB ▲ +9 B (+0.04% ) 21.8 kB
Skeleton ▲ +30 B (+0.05% ) 60.9 kB ▲ +9 B (+0.05% ) 19.1 kB
Slider ▲ +30 B (+0.04% ) 73.8 kB ▲ +9 B (+0.04% ) 23.3 kB
SnackbarContent ▲ +30 B (+0.05% ) 64.1 kB ▲ +9 B (+0.04% ) 20.1 kB
SpeedDialIcon ▲ +30 B (+0.05% ) 63 kB ▲ +9 B (+0.05% ) 19.8 kB
Step ▲ +30 B (+0.05% ) 61.1 kB ▲ +9 B (+0.05% ) 19.1 kB
StepConnector ▲ +30 B (+0.05% ) 61.2 kB ▲ +9 B (+0.05% ) 19.2 kB
StepLabel ▲ +30 B (+0.04% ) 67 kB ▲ +9 B (+0.04% ) 21 kB
Stepper ▲ +30 B (+0.05% ) 63.2 kB ▲ +9 B (+0.05% ) 19.9 kB
SvgIcon ▲ +30 B (+0.05% ) 61.5 kB ▲ +9 B (+0.05% ) 19.1 kB
Table ▲ +30 B (+0.05% ) 61 kB ▲ +9 B (+0.05% ) 19.1 kB
TableBody ▲ +30 B (+0.05% ) 60.5 kB ▲ +9 B (+0.05% ) 18.9 kB
TableCell ▲ +30 B (+0.05% ) 62.5 kB ▲ +9 B (+0.05% ) 19.6 kB
TableFooter ▲ +30 B (+0.05% ) 60.6 kB ▲ +9 B (+0.05% ) 18.9 kB
TableHead ▲ +30 B (+0.05% ) 60.6 kB ▲ +9 B (+0.05% ) 18.9 kB
TableRow ▲ +30 B (+0.05% ) 61 kB ▲ +9 B (+0.05% ) 19.1 kB
ToggleButtonGroup ▲ +30 B (+0.05% ) 61.6 kB ▲ +9 B (+0.05% ) 19.4 kB
TreeView ▲ +30 B (+0.05% ) 64.4 kB ▲ +9 B (+0.04% ) 20.1 kB
Typography ▲ +30 B (+0.05% ) 62.1 kB ▲ +9 B (+0.05% ) 19.3 kB
@material-ui/styles ▲ +30 B (+0.06% ) 50.8 kB ▲ +8 B (+0.05% ) 15.4 kB
ExpansionPanelSummary ▲ +30 B (+0.04% ) 76.4 kB ▲ +8 B (+0.03% ) 24.1 kB
FilledInput ▲ +30 B (+0.04% ) 72 kB ▲ +8 B (+0.04% ) 22.3 kB
Input ▲ +30 B (+0.04% ) 70.9 kB ▲ +8 B (+0.04% ) 22.1 kB
Paper ▲ +30 B (+0.05% ) 60.7 kB ▲ +8 B (+0.04% ) 18.9 kB
Snackbar ▲ +30 B (+0.04% ) 75.6 kB ▲ +8 B (+0.03% ) 23.5 kB
SpeedDialAction ▲ +30 B (+0.03% ) 114 kB ▲ +8 B (+0.02% ) 36 kB
StepButton ▲ +30 B (+0.04% ) 80.6 kB ▲ +8 B (+0.03% ) 25.3 kB
StepContent ▲ +30 B (+0.04% ) 67.4 kB ▲ +8 B (+0.04% ) 21 kB
StepIcon ▲ +30 B (+0.05% ) 63.1 kB ▲ +8 B (+0.04% ) 19.6 kB
Switch ▲ +30 B (+0.04% ) 79.3 kB ▲ +8 B (+0.03% ) 24.7 kB
TableSortLabel ▲ +30 B (+0.04% ) 75.6 kB ▲ +8 B (+0.03% ) 23.9 kB
ToggleButton ▲ +30 B (+0.04% ) 74.4 kB ▲ +8 B (+0.03% ) 23.5 kB
Tooltip ▲ +30 B (+0.03% ) 97.7 kB ▲ +8 B (+0.03% ) 30.9 kB
TreeItem ▲ +30 B (+0.04% ) 71.8 kB ▲ +8 B (+0.04% ) 22.6 kB
Autocomplete ▲ +30 B (+0.02% ) 125 kB ▲ +7 B (+0.02% ) 39.5 kB
BottomNavigationAction ▲ +30 B (+0.04% ) 73.8 kB ▲ +7 B (+0.03% ) 23.3 kB
Button ▲ +30 B (+0.04% ) 77.7 kB ▲ +7 B (+0.03% ) 24 kB
ButtonBase ▲ +30 B (+0.04% ) 72.3 kB ▲ +7 B (+0.03% ) 22.6 kB
CardActionArea ▲ +30 B (+0.04% ) 73.3 kB ▲ +7 B (+0.03% ) 23.1 kB
Checkbox ▲ +30 B (+0.04% ) 80 kB ▲ +7 B (+0.03% ) 25.1 kB
Chip ▲ +30 B (+0.04% ) 80.9 kB ▲ +7 B (+0.03% ) 24.7 kB
Collapse ▲ +30 B (+0.05% ) 66.3 kB ▲ +7 B (+0.03% ) 20.5 kB
Dialog ▲ +30 B (+0.04% ) 80.9 kB ▲ +7 B (+0.03% ) 25.1 kB
docs.main ▲ +30 B (0.00% ) 602 kB ▲ +7 B (0.00% ) 192 kB
ExpansionPanel ▲ +30 B (+0.04% ) 69.7 kB ▲ +7 B (+0.03% ) 21.7 kB
IconButton ▲ +30 B (+0.04% ) 74.4 kB ▲ +7 B (+0.03% ) 23.2 kB
InputBase ▲ +30 B (+0.04% ) 69 kB ▲ +7 B (+0.03% ) 21.6 kB
ListItem ▲ +30 B (+0.04% ) 75.4 kB ▲ +7 B (+0.03% ) 23.5 kB
Menu ▲ +30 B (+0.03% ) 86.6 kB ▲ +7 B (+0.03% ) 27.2 kB
MenuList ▲ +30 B (+0.05% ) 64.4 kB ▲ +7 B (+0.03% ) 20.1 kB
OutlinedInput ▲ +30 B (+0.04% ) 72.4 kB ▲ +7 B (+0.03% ) 22.5 kB
Popover ▲ +30 B (+0.04% ) 81 kB ▲ +7 B (+0.03% ) 25 kB
Select ▲ +30 B (+0.03% ) 112 kB ▲ +7 B (+0.02% ) 33.4 kB
SpeedDial ▲ +30 B (+0.04% ) 84.3 kB ▲ +7 B (+0.03% ) 26.5 kB
SwipeableDrawer ▲ +30 B (+0.03% ) 90.1 kB ▲ +7 B (+0.03% ) 27.9 kB
Tab ▲ +30 B (+0.04% ) 74.6 kB ▲ +7 B (+0.03% ) 23.6 kB
TablePagination ▲ +30 B (+0.02% ) 139 kB ▲ +7 B (+0.02% ) 40.5 kB
@material-ui/core ▲ +30 B (+0.01% ) 349 kB ▲ +6 B (+0.01% ) 95.4 kB
Backdrop ▲ +30 B (+0.05% ) 66.2 kB ▲ +6 B (+0.03% ) 20.4 kB
Fab ▲ +30 B (+0.04% ) 75.1 kB ▲ +6 B (+0.03% ) 23.3 kB
MenuItem ▲ +30 B (+0.04% ) 76.4 kB ▲ +5 B (+0.02% ) 23.8 kB
Tabs ▲ +30 B (+0.04% ) 83.7 kB ▲ +5 B (+0.02% ) 26.6 kB
@material-ui/system -- 14.8 kB -- 4.07 kB
Box -- 69.2 kB -- 20.9 kB
ClickAwayListener -- 3.85 kB -- 1.55 kB
colorManipulator -- 3.83 kB -- 1.52 kB
CssBaseline -- 56 kB -- 17.5 kB
docs.landing -- 56 kB -- 14.6 kB
Fade -- 22 kB -- 7.6 kB
Grow -- 22.6 kB -- 7.72 kB
Modal -- 14.2 kB -- 4.96 kB
NoSsr -- 2.19 kB -- 1.04 kB
Popper -- 28.5 kB -- 10.2 kB
Portal -- 2.87 kB -- 1.29 kB
RootRef -- 4.43 kB -- 1.67 kB
Slide -- 24.1 kB -- 8.21 kB
styles/createMuiTheme -- 15.2 kB -- 5.36 kB
TextareaAutosize -- 5.06 kB -- 2.11 kB
useAutocomplete -- 11.1 kB -- 4.21 kB
useMediaQuery -- 2.49 kB -- 1.05 kB
Zoom -- 22.1 kB -- 7.6 kB

Generated by 🚫 dangerJS against 07c4de0

@eps1lon eps1lon added bug 🐛 Something doesn't work package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. labels Oct 31, 2019
@eps1lon eps1lon changed the title fix: get correct/all props in jss callbacks [styles] Fix props based styles callback not including defaultProps Oct 31, 2019
oliviertassinari
oliviertassinari approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 For a closer behavior to react-jss. Adding it to a minor label, hopefully, it won't break people's app.

@oliviertassinari oliviertassinari added this to the v4.6.0 milestone Nov 2, 2019
@oliviertassinari oliviertassinari merged commit 477f059 into mui:master Nov 3, 2019
@oliviertassinari
Copy link
Member

@salmanm Thanks

@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding approved these changes

@eps1lon eps1lon eps1lon approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Milestone
v4.6.0
Development

Successfully merging this pull request may close these issues.

JSS callback doesn't get complete props
5 participants
@salmanm @mui-pr-bot @oliviertassinari @eps1lon @joshwooding