[Autocomplete] Fix aria-controls and aria-activedescendant #18142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
accessibility
eps1lon
commented
Nov 1, 2019
|
|
||
| fireEvent.keyDown(document.activeElement, { key: 'Escape' }); | ||
|
|
||
| expect(handleClose.callCount).to.equal(1); |
There was a problem hiding this comment.
This will be called twice with jsdom actual because the implementation includes a .focus() noop that causes jsdom to fire a blur event which also calls onClose. In the browser this will work correctly.
eps1lon
force-pushed
the
test/autocomplete
branch
from
0efec53
to
24b80cb
Compare
Details of bundle changes.Comparing: 13b3a0d...24b80cb
|
| }), | ||
| getListboxProps: () => ({ | ||
| role: 'listbox', | ||
| id: `${id}-listbox`, | ||
| id: `${id}-popup`, |
There was a problem hiding this comment.
If the role of this element is listbox, should we suffix the id with -listbox?
There was a problem hiding this comment.
The popup is the generic term for the "list" of possible items. It can also be a grid or tree. It makes more sense if you look at the aria-controls which doesn't care if you have a listbox or grid or tree. Just that the element in question is the popup with the possible items.
There was a problem hiding this comment.
This seems correct, oops 🙃. What do you think of killing the getPopupProps() method and renaming PopupComponent to PopperComponent? (for future changes)
There was a problem hiding this comment.
I thought that the popup was a different element to the listbox. As you raised it out, it's not. Because the default value for PopupComponent is a Popper, the change could make the API more intuitive.
This was referenced Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm splitting work into smaller chunks starting with closing #18132
Tests https://www.w3.org/TR/wai-aria-1.1/#combobox except accessible name computation and keyboard navigation.
I'll remove the
jsdompatch once this gets approved. It's easier to see that this is an issue with jsdom not our implementation