[core] Batch small changes #18155

oliviertassinari · 2019-11-02T21:52:27Z

[docs] Link https://material-ui.com/versions/ 97c786e:

This will enable developer landing on an old version to easily find its way to
a different version.

The idea was sparked by https://www.ag-grid.com/archive/.

[examples] Remove parcel aee9c28

I have added a Parcel demo 18 months ago, anticipating it would gain traction.
#10575

As it turns out, I was wrong. I think that it's too early to have an official example with Parcel.
Our example has outdated dependencies.

https://npm-stat.com/charts.html?package=parcel-bundler&package=preact&package=webpack&from=2017-11-01&to=2019-11-01

For instance, Preact has more traction, it would be better to improve our example for it.

[docs] Add missing 180px icon c61c376
Thank you Tom 7ffea82: @pelotom
[docs] Remove Blokt backer ce46e11: Stop the subscription
[docs] Remove Book affiliation ed5de1c: This is not interesting. It yields about $5/month.
[TableCell] Smaller source 652d801
[CHANGELOG] Fix typos 8e8a7d1
[docs] Use rel=sponsored where appropriate 2c5ba7e

Bring to light by Sebastian, for more details:
https://moz.com/blog/nofollow-sponsored-ugc

[docs] Reduce diffs, isolate changes e5df4c9: the latest change had a negative impact. I try to course correct.
[core] Prefer parentNode over parentElement d3d4b5c

They are very close, it seems that the difference won't impact us.
https://stackoverflow.com/questions/8685739/difference-between-dom-parentnode-and-parentelement

I went with parentNode as more frequent in the codebase.

[docs] Stop date picker survey 48bf385: the results, I will tweet about it. https://www.surveymonkey.com/results/SM-ZR2PJF7Q7/
[Autocomplete] Add active custom state 1afe627

This will enable developer landing on an old version to easy find its way to a different version. The idea was sparked by https://www.ag-grid.com/archive/.

I have added a Parcel demo 18 months ago, anticipating it would gain traction. mui#10575 As it turns out, I was wrong. I think that it's too early to have an official example with Parcel. Our example has outdated dependencies. https://npm-stat.com/charts.html?package=parcel-bundler&package=preact&package=webpack&from=2017-11-01&to=2019-11-01 For instance, Preact has more traction, it would be better to improve our example for it.

This is not interesting. It yields about $5/month.

Bring to light by Sebastien, for more details: https://moz.com/blog/nofollow-sponsored-ugc

They are very close, it seems that the difference will never impact us. https://stackoverflow.com/questions/8685739/difference-between-dom-parentnode-and-parentelement I went with parentNode as more frequent in the codebase.

mui-pr-bot · 2019-11-02T22:19:36Z

Details of bundle changes.

Comparing: 5536e45...0833092

bundle	Size Change	Size	Gzip Change	Gzip
docs.landing	▼ -375 B (-0.67% )	55.6 kB	▼ -23 B (-0.16% )	14.6 kB
docs.main	▲ +69 B (+0.01% )	602 kB	▼ -6 B (-0.00% )	192 kB
TableCell	▼ -32 B (-0.05% )	62.5 kB	▼ -13 B (-0.07% )	19.6 kB
TablePagination	▼ -29 B (-0.02% )	139 kB	▼ -14 B (-0.03% )	40.5 kB
@material-ui/core	▼ -20 B (-0.01% )	349 kB	▼ -16 B (-0.02% )	95.4 kB
@material-ui/core[umd]	▼ -20 B (-0.01% )	308 kB	▼ -11 B (-0.01% )	88.7 kB
GridListTile	▲ +6 B (+0.01% )	62.2 kB	▲ +1 B (+0.01% )	19.5 kB
Popover	▲ +3 B (0.00% )	81 kB	▼ -2 B (-0.01% )	25 kB
Select	▲ +3 B (0.00% )	112 kB	▼ -2 B (-0.01% )	33.4 kB
SwipeableDrawer	▲ +3 B (0.00% )	90.1 kB	▲ +2 B (+0.01% )	27.9 kB
TextField	▲ +3 B (0.00% )	121 kB	▼ -2 B (-0.01% )	35.4 kB
Menu	▲ +3 B (0.00% )	86.6 kB	▲ +1 B (0.00% )	27.2 kB
@material-ui/lab	--	168 kB	--	50.6 kB
@material-ui/styles	--	50.8 kB	--	15.4 kB
@material-ui/system	--	14.8 kB	--	4.07 kB
AppBar	--	62.2 kB	--	19.5 kB
Autocomplete	--	125 kB	--	39.5 kB
Avatar	--	61.1 kB	--	19.2 kB
Backdrop	--	66.2 kB	--	20.4 kB
Badge	--	63.8 kB	--	19.7 kB
BottomNavigation	--	60.8 kB	--	19 kB
BottomNavigationAction	--	73.8 kB	--	23.3 kB
Box	--	69.2 kB	--	20.9 kB
Breadcrumbs	--	66.4 kB	--	20.8 kB
Button	--	77.8 kB	--	24.1 kB
ButtonBase	--	72.3 kB	--	22.6 kB
ButtonGroup	--	62.7 kB	--	19.5 kB
Card	--	61.2 kB	--	19.1 kB
CardActionArea	--	73.3 kB	--	23.1 kB
CardActions	--	60.5 kB	--	18.9 kB
CardContent	--	60.4 kB	--	18.9 kB
CardHeader	--	63.5 kB	--	20 kB
CardMedia	--	60.8 kB	--	19.1 kB
Checkbox	--	80 kB	--	25.1 kB
Chip	--	80.9 kB	--	24.7 kB
CircularProgress	--	62.5 kB	--	19.7 kB
ClickAwayListener	--	3.85 kB	--	1.55 kB
Collapse	--	66.3 kB	--	20.5 kB
colorManipulator	--	3.83 kB	--	1.52 kB
Container	--	61.6 kB	--	19.2 kB
CssBaseline	--	56 kB	--	17.5 kB
Dialog	--	80.9 kB	--	25.1 kB
DialogActions	--	60.5 kB	--	18.9 kB
DialogContent	--	60.7 kB	--	19 kB
DialogContentText	--	62.5 kB	--	19.6 kB
DialogTitle	--	62.7 kB	--	19.7 kB
Divider	--	61 kB	--	19.1 kB
Drawer	--	82.7 kB	--	25.6 kB
ExpansionPanel	--	69.7 kB	--	21.7 kB
ExpansionPanelActions	--	60.5 kB	--	18.9 kB
ExpansionPanelDetails	--	60.4 kB	--	18.9 kB
ExpansionPanelSummary	--	76.4 kB	--	24.1 kB
Fab	--	75.1 kB	--	23.3 kB
Fade	--	22 kB	--	7.6 kB
FilledInput	--	72 kB	--	22.3 kB
FormControl	--	62.8 kB	--	19.5 kB
FormControlLabel	--	64 kB	--	20.1 kB
FormGroup	--	60.5 kB	--	18.9 kB
FormHelperText	--	61.7 kB	--	19.3 kB
FormLabel	--	61.9 kB	--	19.1 kB
Grid	--	63.5 kB	--	19.9 kB
GridList	--	60.9 kB	--	19.1 kB
GridListTileBar	--	61.7 kB	--	19.3 kB
Grow	--	22.6 kB	--	7.72 kB
Hidden	--	64.5 kB	--	20.2 kB
Icon	--	61.2 kB	--	19.2 kB
IconButton	--	74.4 kB	--	23.2 kB
Input	--	70.9 kB	--	22.1 kB
InputAdornment	--	63.5 kB	--	20 kB
InputBase	--	69.1 kB	--	21.6 kB
InputLabel	--	63.8 kB	--	19.8 kB
LinearProgress	--	63.8 kB	--	19.9 kB
Link	--	65 kB	--	20.6 kB
List	--	60.8 kB	--	18.9 kB
ListItem	--	75.4 kB	--	23.5 kB
ListItemAvatar	--	60.6 kB	--	18.9 kB
ListItemIcon	--	60.6 kB	--	19 kB
ListItemSecondaryAction	--	60.5 kB	--	18.9 kB
ListItemText	--	63.4 kB	--	19.9 kB
ListSubheader	--	61.2 kB	--	19.2 kB
MenuItem	--	76.4 kB	--	23.8 kB
MenuList	--	64.4 kB	--	20.1 kB
MobileStepper	--	66.2 kB	--	20.6 kB
Modal	--	14.2 kB	--	4.96 kB
NativeSelect	--	75.2 kB	--	23.7 kB
NoSsr	--	2.19 kB	--	1.04 kB
OutlinedInput	--	72.5 kB	--	22.5 kB
Paper	--	60.7 kB	--	18.9 kB
Popper	--	28.5 kB	--	10.2 kB
Portal	--	2.87 kB	--	1.29 kB
Radio	--	80.9 kB	--	25.4 kB
RadioGroup	--	61.7 kB	--	19.3 kB
Rating	--	68.3 kB	--	21.8 kB
RootRef	--	4.43 kB	--	1.67 kB
Skeleton	--	60.9 kB	--	19.1 kB
Slide	--	24.1 kB	--	8.21 kB
Slider	--	73.8 kB	--	23.3 kB
Snackbar	--	75.6 kB	--	23.5 kB
SnackbarContent	--	64.1 kB	--	20.1 kB
SpeedDial	--	84.3 kB	--	26.5 kB
SpeedDialAction	--	114 kB	--	36 kB
SpeedDialIcon	--	63 kB	--	19.8 kB
Step	--	61.1 kB	--	19.1 kB
StepButton	--	80.6 kB	--	25.3 kB
StepConnector	--	61.2 kB	--	19.2 kB
StepContent	--	67.4 kB	--	21 kB
StepIcon	--	63.1 kB	--	19.6 kB
StepLabel	--	67 kB	--	21 kB
Stepper	--	63.2 kB	--	19.9 kB
styles/createMuiTheme	--	15.2 kB	--	5.36 kB
SvgIcon	--	61.5 kB	--	19.1 kB
Switch	--	79.3 kB	--	24.7 kB
Tab	--	74.6 kB	--	23.6 kB
Table	--	61 kB	--	19.1 kB
TableBody	--	60.5 kB	--	18.9 kB
TableFooter	--	60.6 kB	--	18.9 kB
TableHead	--	60.6 kB	--	18.9 kB
TableRow	--	61 kB	--	19.1 kB
TableSortLabel	--	75.6 kB	--	23.9 kB
Tabs	--	83.7 kB	--	26.6 kB
TextareaAutosize	--	5.06 kB	--	2.11 kB
ToggleButton	--	74.4 kB	--	23.5 kB
ToggleButtonGroup	--	61.6 kB	--	19.4 kB
Toolbar	--	60.8 kB	--	19 kB
Tooltip	--	97.7 kB	--	30.9 kB
TreeItem	--	71.8 kB	--	22.6 kB
TreeView	--	64.4 kB	--	20.1 kB
Typography	--	62.1 kB	--	19.3 kB
useAutocomplete	--	11.1 kB	--	4.21 kB
useMediaQuery	--	2.49 kB	--	1.05 kB
Zoom	--	22.1 kB	--	7.6 kB

Generated by 🚫 dangerJS against 0833092

oliviertassinari added 11 commits November 2, 2019 20:09

[docs] Link https://material-ui.com/versions/

97c786e

This will enable developer landing on an old version to easy find its way to a different version. The idea was sparked by https://www.ag-grid.com/archive/.

[docs] Add missing 180px icon

c61c376

Thank you Tom

7ffea82

[docs] Remove Blokt backer

ce46e11

[docs] Remove Book affiliation

ed5de1c

This is not interesting. It yields about $5/month.

[TableCell] Smaller source

652d801

[CHANGELOG] Fix typos

8e8a7d1

[docs] Use rel=sponsored where appropriate

2c5ba7e

Bring to light by Sebastien, for more details: https://moz.com/blog/nofollow-sponsored-ugc

[docs] Reduce diffs, isolate changes

e5df4c9

[core] Prefer parentNode over parentElement

d3d4b5c

They are very close, it seems that the difference will never impact us. https://stackoverflow.com/questions/8685739/difference-between-dom-parentnode-and-parentelement I went with parentNode as more frequent in the codebase.

oliviertassinari added the umbrella For grouping multiple issues to provide a holistic view label Nov 2, 2019

[docs] Stop date picker survey

8484f45

oliviertassinari force-pushed the batch-small-changes-v13 branch from 48bf385 to 8484f45 Compare November 2, 2019 22:00

[Autocomplete] Add active custom state

1afe627

Sebastian review

4bed824

oliviertassinari force-pushed the batch-small-changes-v13 branch 2 times, most recently from 2e9044b to bee30a9 Compare November 3, 2019 11:28

Follow up after discussion with Matt

d9d4620

oliviertassinari force-pushed the batch-small-changes-v13 branch from bee30a9 to d9d4620 Compare November 3, 2019 11:31

oliviertassinari added the PR: ready to ship label Nov 3, 2019

Fix small SEO issues

0833092

oliviertassinari merged commit 3e25d1b into mui:master Nov 4, 2019

oliviertassinari deleted the batch-small-changes-v13 branch November 4, 2019 08:33

oliviertassinari mentioned this pull request Nov 4, 2019

[docs] /versions page rate limited issue with GitHub API #14762

Closed

2 tasks

snyk-bot mentioned this pull request Jan 7, 2020

[Snyk] Upgrade @material-ui/core from 4.4.0 to 4.8.2 srdjan-19/rent-a-car-service#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Batch small changes #18155

[core] Batch small changes #18155

oliviertassinari commented Nov 2, 2019 •

edited

Loading

mui-pr-bot commented Nov 2, 2019 •

edited

Loading

[core] Batch small changes #18155

[core] Batch small changes #18155

Conversation

oliviertassinari commented Nov 2, 2019 • edited Loading

mui-pr-bot commented Nov 2, 2019 • edited Loading

oliviertassinari commented Nov 2, 2019 •

edited

Loading

mui-pr-bot commented Nov 2, 2019 •

edited

Loading