Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Fix tests polluting DOM #18163

Merged
merged 1 commit into from
Nov 3, 2019
Merged

[test] Fix tests polluting DOM #18163

merged 1 commit into from
Nov 3, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Nov 3, 2019 •
edited
Loading

Since cleanup runs in a afterAll hook setup has to run in a beforeAll hook. The hooks need to be symmetric. It was only a minor inconvenience when debuggin (the containers from createMount got printed in the console).

Aside:

  • TreeView conformance suite is run in StrictMode (only TreeItem is problematic)

@eps1lon eps1lon added the test label Nov 3, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing 22c7916...19eb678

Generated by 🚫 dangerJS against 19eb678

@eps1lon eps1lon merged commit 5536e45 into mui:master Nov 3, 2019
@eps1lon eps1lon deleted the test/cleanup-dom branch November 3, 2019 16:35
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari