-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TreeView] Add controlled API to TreeView #18165
[TreeView] Add controlled API to TreeView #18165
Conversation
Details of bundle changes.Comparing: cc4e428...4ed379a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great start!
29107d2
to
d098f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a full controllable test? Maybe the demo is enough. So I only have one feedback, see my comment below. Almost good to ship :)
What do you mean by full controllable test? |
@joshwooding I meant a test that is similar to the demo, a test where we control the tree view. I have explored a bit of how we could unify the logic: joshwooding#2. |
Not sure if the types are right, @eps1lon can you check them for me please :) @oliviertassinari Was this what you were expecting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it
Closes #17705
Just a starting point, to start conversation.
TODO
Breaking change